Page MenuHomeFreeBSD
Differential D50532

vfs cache: Add NAMEILOOKUP to the whitelist of fastpath lookup flags
ClosedPublic
Actions

Authored by markj on May 26 2025, 1:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 16, 1:18 PM
Unknown Object (File)
Fri, Dec 12, 8:05 AM
Unknown Object (File)
Thu, Nov 27, 11:22 AM
Unknown Object (File)
Wed, Nov 26, 11:53 PM
Unknown Object (File)
Nov 13 2025, 10:57 PM
Unknown Object (File)
Nov 3 2025, 12:34 PM
Unknown Object (File)
Nov 3 2025, 12:31 PM
Unknown Object (File)
Nov 3 2025, 12:27 PM
View All 53 Files
Subscribers
imp

Details

Reviewers
jamie
olce
kib
Commits
rGadb8c1a9d09d: vfs cache: Add NAMEILOOKUP to the whitelist of fastpath lookup flags
rG031cd548775c: vfs cache: Add NAMEILOOKUP to the whitelist of fastpath lookup flags
rGf4158953007f: vfs cache: Add NAMEILOOKUP to the whitelist of fastpath lookup flags
Summary

Fixes: 7587f6d4840f ("namei: Make stackable filesystems check harder for jail roots")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.May 26 2025, 1:57 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 26 2025, 1:57 PM
markj requested review of this revision.May 26 2025, 1:57 PM
Harbormaster completed remote builds in B64440: Diff 156050.May 26 2025, 1:57 PM
markj added a parent revision: D50531: vfs: Don't clobber namei flags in vn_open_cred().May 26 2025, 1:57 PM
markj added a child revision: D50533: tests: Add a regression test for commit 7587f6d4840f8.
kib accepted this revision.May 26 2025, 4:53 PM

So otherwise fast lookup is effectively turned off?

This revision is now accepted and ready to land.May 26 2025, 4:53 PM
markj added a comment.May 26 2025, 4:54 PM
In D50532#1153545, @kib wrote:

So otherwise fast lookup is effectively turned off?

Yes, though not for open(2) because of the other bug (overwriting cn_flags).

olce accepted this revision.May 27 2025, 1:02 PM
Closed by commit rGf4158953007f: vfs cache: Add NAMEILOOKUP to the whitelist of fastpath lookup flags (authored by markj). · Explain WhyMay 27 2025, 2:39 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGf4158953007f: vfs cache: Add NAMEILOOKUP to the whitelist of fastpath lookup flags.
markj added a commit: rG031cd548775c: vfs cache: Add NAMEILOOKUP to the whitelist of fastpath lookup flags.Jun 30 2025, 2:21 PM
markj added a commit: rGadb8c1a9d09d: vfs cache: Add NAMEILOOKUP to the whitelist of fastpath lookup flags.Fri, Nov 21, 3:20 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
2 lines

Diff 156092

View Options

sys/kern/vfs_cache.c

Loading...