Page MenuHomeFreeBSD
Differential D50532

vfs cache: Add NAMEILOOKUP to the whitelist of fastpath lookup flags
ClosedPublic
Actions

Authored by markj on May 26 2025, 1:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Aug 19, 11:01 PM
Unknown Object (File)
Sun, Aug 17, 11:32 PM
Unknown Object (File)
Thu, Aug 14, 12:34 AM
Unknown Object (File)
Mon, Aug 11, 11:20 AM
Unknown Object (File)
Sat, Aug 9, 6:55 AM
Unknown Object (File)
Sat, Jul 26, 2:36 AM
Unknown Object (File)
Jul 21 2025, 4:17 PM
Unknown Object (File)
Jul 21 2025, 7:45 AM
View All 31 Files
Subscribers
imp

Details

Reviewers
jamie
olce
kib
Commits
rG031cd548775c: vfs cache: Add NAMEILOOKUP to the whitelist of fastpath lookup flags
rGf4158953007f: vfs cache: Add NAMEILOOKUP to the whitelist of fastpath lookup flags
Summary

Fixes: 7587f6d4840f ("namei: Make stackable filesystems check harder for jail roots")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64440
Build 61324: arc lint + arc unit

Event Timeline

markj created this revision.May 26 2025, 1:57 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 26 2025, 1:57 PM
markj requested review of this revision.May 26 2025, 1:57 PM
Harbormaster completed remote builds in B64440: Diff 156050.May 26 2025, 1:57 PM
markj added a parent revision: D50531: vfs: Don't clobber namei flags in vn_open_cred().May 26 2025, 1:57 PM
markj added a child revision: D50533: tests: Add a regression test for commit 7587f6d4840f8.
kib accepted this revision.May 26 2025, 4:53 PM

So otherwise fast lookup is effectively turned off?

This revision is now accepted and ready to land.May 26 2025, 4:53 PM
markj added a comment.May 26 2025, 4:54 PM
In D50532#1153545, @kib wrote:

So otherwise fast lookup is effectively turned off?

Yes, though not for open(2) because of the other bug (overwriting cn_flags).

olce accepted this revision.May 27 2025, 1:02 PM
Closed by commit rGf4158953007f: vfs cache: Add NAMEILOOKUP to the whitelist of fastpath lookup flags (authored by markj). · Explain WhyMay 27 2025, 2:39 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGf4158953007f: vfs cache: Add NAMEILOOKUP to the whitelist of fastpath lookup flags.
markj added a commit: rG031cd548775c: vfs cache: Add NAMEILOOKUP to the whitelist of fastpath lookup flags.Jun 30 2025, 2:21 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
2 lines

Diff 156050

View Options

sys/kern/vfs_cache.c

Loading...