Differential D50344

release: use pkg install -f
ClosedPublic
Actions

Authored by ifreund_freebsdfoundation.org on Wed, May 14, 10:08 AM.

Details

Reviewers

emaste

Group Reviewers

releng

Commits

rG1203e7b1f05b: release: Use pkg install -f

Summary

Without -f, pkg will not write to the METALOG file if the packages
are already installed from a previous build, causing the packages to
not be included in the final install media.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 64159
Build 61043: arc lint + arc unit

Event Timeline

ifreund_freebsdfoundation.org created this revision.Wed, May 14, 10:08 AM

Herald added subscribers: jrtc27, imp. · View Herald TranscriptWed, May 14, 10:08 AM

ifreund_freebsdfoundation.org requested review of this revision.Wed, May 14, 10:08 AM

Harbormaster completed remote builds in B64159: Diff 155430.Wed, May 14, 10:08 AM

ifreund_freebsdfoundation.org mentioned this in D50342: release: fix pkg METALOG in Makefile.Wed, May 14, 10:09 AM

ifreund_freebsdfoundation.org added a reviewer: releng.

Git branch: https://github.com/ifreund/freebsd-src/tree/bsdinstall-offline-pkgbase

The release artifact targets have some problems with re-running, and we should really either be able to reuse the previously staged package install, or forcibly start with a clean target location. That said, the official builds are always done in a fresh/clean directory and won't encounter issues of this sort, and there won't be any potential downside from this change there. So I'm happy with this to aid with iteration in developing the release targets.

This revision is now accepted and ready to land.Wed, May 14, 12:21 PM

Closed by commit rG1203e7b1f05b: release: Use pkg install -f (authored by ifreund_freebsdfoundation.org, committed by emaste). · Explain WhyWed, May 14, 12:55 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG1203e7b1f05b: release: Use pkg install -f.

guest-patmaddox added a subscriber: guest-patmaddox.Tue, May 20, 6:43 PM