release: fix pkg METALOG in Makefile
AbandonedPublic
Actions

Authored by ifreund_freebsdfoundation.org on May 14 2025, 7:42 AM.

Details

Reviewers

Group Reviewers

Summary

From my testing, none of the PKG_INSTALL invocations in release/Makefile
actually work currently due to pkg writing to the wrong METALOG file.

Since PKG_ARGS refers to the METALOG in the working directory, we must
be careful to run pkg from the directory containing the correct METALOG.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 64156
Build 61040: arc lint + arc unit

Event Timeline

ifreund_freebsdfoundation.org created this revision.May 14 2025, 7:42 AM

Herald added subscribers: jrtc27, imp. · View Herald TranscriptMay 14 2025, 7:42 AM

ifreund_freebsdfoundation.org requested review of this revision.May 14 2025, 7:42 AM

ifreund_freebsdfoundation.org added a reviewer: releng.May 14 2025, 7:43 AM

Harbormaster completed remote builds in B64156: Diff 155425.May 14 2025, 7:43 AM

Uh I'm not sure how I messed up my testing but this patch is incorrect, everything works fine since pkg interprets the METALOG option relative to the rootdir option.

Sorry for the noise.

ifreund_freebsdfoundation.org abandoned this revision.May 14 2025, 8:51 AM

Aha! The thing I was seeing happened again and I think I understand it now, submitted D50344.

guest-patmaddox added a subscriber: guest-patmaddox.Tue, May 20, 6:43 PM

Revision Contents
Changeset List

Path

Size

release/

Makefile

19 lines

Diff 155425

View Options

release: fix pkg METALOG in MakefileAbandonedPublicActions