Differential D50302

man: Exit cleanly on SIGPIPE.
ClosedPublic
Actions

Authored by des on Sun, May 11, 10:02 PM.

Tags

None

Referenced Files

	F118783607: D50302.id155562.diff
	Sun, Jun 1, 9:23 PM

	F118781906: D50302.id155305.diff
	Sun, Jun 1, 8:59 PM

	F118737797: D50302.id155562.diff
	Sun, Jun 1, 9:48 AM

	Unknown Object (File)
	Sun, Jun 1, 5:30 AM

	Unknown Object (File)
	Thu, May 29, 9:07 AM

	Unknown Object (File)
	Wed, May 28, 4:12 PM

	Unknown Object (File)
	Wed, May 28, 4:12 PM

	Unknown Object (File)
	Wed, May 28, 4:12 PM

View All 15 Files

Subscribers

Details

Reviewers

ziaee
kevans

Group Reviewers

Commits

rG84b971c9186a: man: Exit cleanly on SIGPIPE.
rG2f99190a9234: man: Exit cleanly on SIGPIPE.
rGfbaba7aa4322: man: Exit cleanly on SIGPIPE.

Summary

The first attempt at addressing this simply suppressed SIGPIPE, which
resulted in mandoc printing out error messages instead. This was then
reverted, but the pipefail was (correctly) left in, so man still
returned a nonzero exit code if you quit a page before the end.

Fixes: 14a5c1068d37, a85d870007e7
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 64094
Build 60978: arc lint + arc unit

Event Timeline

des created this revision.Sun, May 11, 10:02 PM

Herald added a subscriber: imp. · View Herald TranscriptSun, May 11, 10:02 PM

des requested review of this revision.Sun, May 11, 10:02 PM

Harbormaster completed remote builds in B64094: Diff 155305.Sun, May 11, 10:02 PM

LGTM + tested, thank you so much!

This revision is now accepted and ready to land.Sun, May 11, 10:19 PM

kevans accepted this revision.Fri, May 16, 1:13 PM

Closed by commit rGfbaba7aa4322: man: Exit cleanly on SIGPIPE. (authored by des). · Explain WhyFri, May 16, 2:57 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGfbaba7aa4322: man: Exit cleanly on SIGPIPE..

des added a commit: rG2f99190a9234: man: Exit cleanly on SIGPIPE..Wed, May 21, 4:57 PM

des added a commit: rG84b971c9186a: man: Exit cleanly on SIGPIPE..Wed, May 21, 5:37 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

man/

15 lines

Diff 155305

usr.bin/man/man.sh

Loading...