Paths

Table of Contentst

Differential D50165

queue(3): Add a test for STAILQ_REVERSE()
ClosedPublic
Actions

Authored by olce on Mon, May 5, 10:22 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 9, 12:59 PM

	Unknown Object (File)
	Fri, May 9, 10:10 AM

	Unknown Object (File)
	Fri, May 9, 1:09 AM

	Unknown Object (File)
	Wed, May 7, 1:42 PM

	Unknown Object (File)
	Tue, May 6, 1:41 PM

	Unknown Object (File)
	Tue, May 6, 8:56 AM

	Unknown Object (File)
	Tue, May 6, 8:22 AM

	Unknown Object (File)
	Tue, May 6, 7:14 AM

Subscribers

Details

Reviewers

kib
markj

Commits

rG0285c2428780: queue(3): Add a test for STAILQ_REVERSE()

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

olce created this revision.Mon, May 5, 10:22 AM

Herald added a subscriber: imp. · View Herald TranscriptMon, May 5, 10:22 AM

olce requested review of this revision.Mon, May 5, 10:22 AM

Harbormaster completed remote builds in B63891: Diff 154837.Mon, May 5, 10:22 AM

olce added a parent revision: D50131: sys/queue.h: add STAILQ_REVERSE.Mon, May 5, 10:34 AM

kib added inline comments.Mon, May 5, 10:37 AM

tests/sys/sys/queue_test.c
270	May be also check STAILQ_FIRST()?
276	Would it make sense to add some checks for the empty stailq after the reverse? Then we would see that the test does not crash, at least, due to a corruption.

olce marked an inline comment as done.Mon, May 5, 12:52 PM

olce added inline comments.

tests/sys/sys/queue_test.c
270	That's already part of the checks performed by *_check() functions.
276	Yes.

Check empty_stailq after applying STAILQ_REVERSE().
Destroy empty_stailq once done.

Harbormaster completed remote builds in B63892: Diff 154846.Mon, May 5, 12:52 PM

olce marked an inline comment as done.Mon, May 5, 12:52 PM

kib accepted this revision.Mon, May 5, 1:05 PM

This revision is now accepted and ready to land.Mon, May 5, 1:05 PM

markj accepted this revision.Tue, May 6, 1:42 PM

Closed by commit rG0285c2428780: queue(3): Add a test for STAILQ_REVERSE() (authored by olce). · Explain WhyWed, May 7, 12:36 PM

This revision was automatically updated to reflect the committed changes.

olce added a commit: rG0285c2428780: queue(3): Add a test for STAILQ_REVERSE().

Revision Contents
Changeset List

Path

Size

tests/

sys/

sys/

58 lines

Diff 155055

tests/sys/sys/queue_test.c

Loading...