Page MenuHomeFreeBSD
Differential D50165

queue(3): Add a test for STAILQ_REVERSE()
ClosedPublic
Actions

Authored by olce on May 5 2025, 10:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 21, 9:54 PM
Unknown Object (File)
Wed, Aug 12, 8:46 PM
Unknown Object (File)
Mon, Aug 10, 11:42 AM
Unknown Object (File)
Sat, Aug 8, 3:04 AM
Unknown Object (File)
Fri, Aug 7, 10:29 PM
Unknown Object (File)
Fri, Aug 7, 11:59 AM
Unknown Object (File)
Thu, Aug 6, 2:21 PM
Unknown Object (File)
Thu, Aug 6, 11:48 AM
View All Files
Subscribers
imp

Details

Reviewers
kib
markj
Commits
rG11716164c1fe: queue(3): Add a test for STAILQ_REVERSE()
rG0285c2428780: queue(3): Add a test for STAILQ_REVERSE()

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce created this revision.May 5 2025, 10:22 AM
Herald added a subscriber: imp. · View Herald TranscriptMay 5 2025, 10:22 AM
olce requested review of this revision.May 5 2025, 10:22 AM
Harbormaster completed remote builds in B63891: Diff 154837.May 5 2025, 10:22 AM
olce added a parent revision: D50131: sys/queue.h: add STAILQ_REVERSE.May 5 2025, 10:34 AM
kib added inline comments.May 5 2025, 10:37 AM
tests/sys/sys/queue_test.c
270

May be also check STAILQ_FIRST()?

276

Would it make sense to add some checks for the empty stailq after the reverse? Then we would see that the test does not crash, at least, due to a corruption.

olce marked an inline comment as done.May 5 2025, 12:52 PM
olce added inline comments.
tests/sys/sys/queue_test.c
270

That's already part of the checks performed by *_check() functions.

276

Yes.

olce updated this revision to Diff 154846.EditedMay 5 2025, 12:52 PM
olce marked an inline comment as done.
  • Check empty_stailq after applying STAILQ_REVERSE().
  • Destroy empty_stailq once done.
Harbormaster completed remote builds in B63892: Diff 154846.May 5 2025, 12:52 PM
olce marked an inline comment as done.May 5 2025, 12:52 PM
kib accepted this revision.May 5 2025, 1:05 PM
This revision is now accepted and ready to land.May 5 2025, 1:05 PM
markj accepted this revision.May 6 2025, 1:42 PM
Closed by commit rG0285c2428780: queue(3): Add a test for STAILQ_REVERSE() (authored by olce). · Explain WhyMay 7 2025, 12:36 PM
This revision was automatically updated to reflect the committed changes.
olce added a commit: rG0285c2428780: queue(3): Add a test for STAILQ_REVERSE().
olce added a commit: rG11716164c1fe: queue(3): Add a test for STAILQ_REVERSE().May 13 2025, 9:27 AM

Revision Contents
Changeset List

PathSize
tests/
sys/
sys/
58 lines

Diff 155055

View Options

tests/sys/sys/queue_test.c

Loading...