Page MenuHomeFreeBSD
Differential D50170

libusb: emit event when deregister event
ClosedPublic
Actions

Authored by aokblast on Mon, May 5, 5:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 19, 9:34 PM
Unknown Object (File)
Mon, May 12, 5:39 AM
Unknown Object (File)
Sun, May 11, 6:58 PM
Unknown Object (File)
Sun, May 11, 2:05 PM
Unknown Object (File)
Sun, May 11, 8:05 AM
Unknown Object (File)
Sat, May 10, 11:57 AM
Unknown Object (File)
Sat, May 10, 10:46 AM
Unknown Object (File)
Thu, May 8, 7:15 PM
View All 9 Files
Subscribers
emaste
imp
lwhsu

Details

Reviewers
bapt
Commits
rG641bb44d8538: libusb: Emit event after deregistering hotplug handler
rGd28526591803: libusb: Emit event after deregistering hotplug handler
Summary

The original implementation emit event when deregister hotplug handler.
Without this, some program follows the best practice from libusb will stuck on waiting an event to trigger after deregister the hotplug handler.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 63913
Build 60797: arc lint + arc unit

Event Timeline

aokblast created this revision.Mon, May 5, 5:54 PM
Herald added a subscriber: imp. · View Herald TranscriptMon, May 5, 5:54 PM
aokblast requested review of this revision.Mon, May 5, 5:54 PM
Harbormaster completed remote builds in B63912: Diff 154888.Mon, May 5, 5:54 PM
aokblast updated this revision to Diff 154889.Mon, May 5, 5:55 PM

Fix commit message

Harbormaster completed remote builds in B63913: Diff 154889.Mon, May 5, 5:55 PM
aokblast retitled this revision from libusb: emit event when deregister to libusb: emit event when deregister event.Mon, May 5, 5:55 PM
aokblast added a reviewer: bapt.

See https://github.com/libusb/libusb/blob/master/libusb/hotplug.c#L459

emaste added a subscriber: emaste.Tue, May 6, 2:18 PM
lwhsu added a subscriber: lwhsu.Tue, May 6, 8:02 PM
aokblast edited the summary of this revision. (Show Details)Wed, May 7, 1:52 PM
bapt added a comment.Wed, May 7, 1:57 PM

While this looks good, I think the commit log should be way more verbose.

aokblast updated this revision to Diff 155062.Wed, May 7, 3:43 PM
aokblast edited the summary of this revision. (Show Details)

Elaborate on the commit message

Harbormaster completed remote builds in B63994: Diff 155062.Wed, May 7, 3:43 PM
aokblast edited the summary of this revision. (Show Details)Wed, May 7, 3:44 PM
bapt accepted this revision.Wed, May 7, 4:14 PM
This revision is now accepted and ready to land.Wed, May 7, 4:14 PM
aokblast added a comment.Thu, May 8, 5:41 PM

For somebody want to merge this patch, thanks:
https://github.com/aokblast/freebsd-src/commit/8548727194b05ff97fb48e6406a6f26f7f54e593

Closed by commit rGd28526591803: libusb: Emit event after deregistering hotplug handler (authored by aokblast, committed by emaste). · Explain WhyThu, May 8, 6:21 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rGd28526591803: libusb: Emit event after deregistering hotplug handler.
emaste added a commit: rG641bb44d8538: libusb: Emit event after deregistering hotplug handler.Wed, May 14, 2:24 PM

Revision Contents
Changeset List

PathSize
lib/
libusb/
1 line
1 line

Diff 154889

View Options

lib/libusb/libusb10_hotplug.c

Loading...
View Options

lib/libusb/libusb10_io.c

Loading...