Page MenuHomeFreeBSD
Differential D50117

thr_rtld: accept read lock requests while owning the lock for write
ClosedPublic
Actions

Authored by kib on Fri, May 2, 3:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 7, 12:23 AM
Unknown Object (File)
Tue, May 6, 3:44 AM
Unknown Object (File)
Mon, May 5, 10:49 AM
Unknown Object (File)
Mon, May 5, 7:52 AM
Unknown Object (File)
Sun, May 4, 1:19 PM
Unknown Object (File)
Fri, May 2, 6:42 PM
Subscribers
imp

Details

Reviewers
markj
olce
Commits
rG812c4bf3f170: thr_rtld: accept read lock requests while owning the lock for write
Summary

PR: 286505

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Fri, May 2, 3:38 PM
Herald added a subscriber: imp. · View Herald TranscriptFri, May 2, 3:38 PM
kib requested review of this revision.Fri, May 2, 3:38 PM
olce accepted this revision.Fri, May 2, 4:15 PM

The logic appears fine. Out of curiosity, could you describe or provide some links to the context of this change? I think I saw several changes passing in rtld recently, but haven't followed.

lib/libthr/thread/thr_rtld.c
175–182

That trick extends the write lock as seen by other threads until all the references from the locking thread have been released (write but also read). Could that be a problem?

This revision is now accepted and ready to land.Fri, May 2, 4:15 PM
kib added a comment.Fri, May 2, 5:41 PM
In D50117#1143243, @olce wrote:

The logic appears fine. Out of curiosity, could you describe or provide some links to the context of this change? I think I saw several changes passing in rtld recently, but haven't followed.

See the referenced PR for the test case.

lib/libthr/thread/thr_rtld.c
175–182

This is the expected behavior, how could it be different? The last reference releases the exclusive/write lock.

Closed by commit rG812c4bf3f170: thr_rtld: accept read lock requests while owning the lock for write (authored by kib). · Explain WhyFri, May 2, 6:09 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG812c4bf3f170: thr_rtld: accept read lock requests while owning the lock for write.
olce added a comment.Fri, May 2, 7:22 PM

Thanks, I hadn't seen it above.

lib/libthr/thread/thr_rtld.c
175–182

I was just wondering if that could be a problem in the context of the change. I do indeed see no other way without splitting _thr_rtld_lock_release() into 2 functions, one for the write lock and another one for read locks.

Revision Contents
Changeset List

PathSize
lib/
libthr/
thread/
26 lines

Diff 154711

View Options

lib/libthr/thread/thr_rtld.c

Loading...