uma_core: replace listq with plinks.q in temp lists
ClosedPublic
Actions

Authored by dougm on Wed, Apr 30, 10:13 PM.

Details

Reviewers

alc
markj
kib

Commits

rG130374a97b24: uma_core: change listq to plinks.q in temp lists

Summary

Change the two functions that use local tailq variables to use the plinks.q field, instead of the listq field, for the pointers.

This should resolve one source of conflict should the tailq field and the object field come to share the same space in some future change to the vm_page definition.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dougm requested review of this revision.Wed, Apr 30, 10:13 PM

dougm created this revision.

Use a single call to pmap_qenter rather than having it in a loop.

Throw it all out, as @alc suggests that the arrays could be too big. Just switch from using listq to using plinks.q for the temporary lists.

kib accepted this revision.Thu, May 1, 3:58 AM

This revision is now accepted and ready to land.Thu, May 1, 3:58 AM

The key here is that all page allocation functions call vm_page_dequeue(), completing any lingering page queue operations that involve the plinks.q field.

Closed by commit rG130374a97b24: uma_core: change listq to plinks.q in temp lists (authored by dougm). · Explain WhyThu, May 1, 6:46 AM

This revision was automatically updated to reflect the committed changes.

dougm added a commit: rG130374a97b24: uma_core: change listq to plinks.q in temp lists.

Herald added a subscriber: imp. · View Herald TranscriptThu, May 1, 6:46 AM