Tags

None

Referenced Files

	F115888165: D49852.diff
	Wed, Apr 30, 1:09 AM

	Unknown Object (File)
	Mon, Apr 28, 9:10 AM

	Unknown Object (File)
	Sun, Apr 27, 2:12 AM

	Unknown Object (File)
	Fri, Apr 25, 11:50 AM

	Unknown Object (File)
	Wed, Apr 23, 10:10 AM

	Unknown Object (File)
	Wed, Apr 23, 10:06 AM

	Unknown Object (File)
	Wed, Apr 23, 7:00 AM

	Unknown Object (File)
	Tue, Apr 22, 9:17 AM

View All 25 Files

Subscribers

imp

riscv

Details

Reviewers

mhorne
jrtc27

Commits

rG81e2d24bc6ea: riscv: support for Cache-Block Operations (CBO).

Summary

Detect zicbom extension and install cache invalidation handlers

Test Plan

The extension found on Codasip X730 and required by AXI DMA engine driver

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

br created this revision.Wed, Apr 16, 3:00 PM

Herald added a subscriber: riscv. · View Herald TranscriptWed, Apr 16, 3:00 PM

br requested review of this revision.Wed, Apr 16, 3:00 PM

jrtc27 added inline comments.Wed, Apr 16, 3:10 PM

sys/conf/kern.mk
166 ↗	(On Diff #153732)	You shouldn't just do that unconditionally. Just `.option push; .option arch, +zicbom ... .option pop` in asm that needs it.
sys/riscv/riscv/cbo.c
48	0 can be dropped for all these, and does the singular operand really need to be named? %0 is fine, surely?
sys/riscv/riscv/identcpu.c
228–229	Obsolete?
354–357	OF_getencprop can fail. But also why not just pass sizeof(desc->foo) and let it check the length for you?

Address @jrtc27 comments.

Remove 0

handle return code of OF_getencprop() correctly

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Apr 22, 9:07 AM

Closed by commit rG81e2d24bc6ea: riscv: support for Cache-Block Operations (CBO). (authored by br). · Explain Why

This revision was automatically updated to reflect the committed changes.

br added a commit: rG81e2d24bc6ea: riscv: support for Cache-Block Operations (CBO)..

Herald added a subscriber: imp. · View Herald TranscriptTue, Apr 22, 9:07 AM

riscv: zicbom extension support
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 154080

sys/conf/files.riscv

sys/riscv/include/cbo.h

sys/riscv/riscv/cbo.c

sys/riscv/riscv/identcpu.c

riscv: zicbom extension supportClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 154080

sys/conf/files.riscv

sys/riscv/include/cbo.h

sys/riscv/riscv/cbo.c

sys/riscv/riscv/identcpu.c

riscv: zicbom extension support
ClosedPublic
Actions

Revision Contents
Changeset List