Page MenuHomeFreeBSD
Differential D49953

mountd: use free_iovec for build_iovec cleanup
ClosedPublic
Actions

Authored by brooks on Apr 21 2025, 10:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 27, 10:42 AM
Unknown Object (File)
Wed, Sep 9, 4:16 PM
Unknown Object (File)
Wed, Sep 9, 4:16 PM
Unknown Object (File)
Wed, Sep 9, 4:13 PM
Unknown Object (File)
Tue, Sep 8, 3:17 PM
Unknown Object (File)
Sun, Sep 6, 6:59 PM
Unknown Object (File)
Sun, Sep 6, 3:38 PM
Unknown Object (File)
Sat, Sep 5, 11:55 AM
View All Files
Subscribers
imp

Details

Reviewers
rmacklem
Commits
rG5fa183f02845: mountd: use free_iovec for build_iovec cleanup
Summary

Remove the handrolled cleanups and the user free_iovec instead.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 63622
Build 60506: arc lint + arc unit

Event Timeline

brooks created this revision.Apr 21 2025, 10:21 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 21 2025, 10:21 PM
brooks requested review of this revision.Apr 21 2025, 10:21 PM
Harbormaster completed remote builds in B63622: Diff 154058.Apr 21 2025, 10:21 PM
rmacklem accepted this revision.Apr 23 2025, 12:08 AM

Looks fine to me, rick

usr.sbin/mountd/mountd.c
2102

If I read the code correctly, the only thing this
patch doesn't do is set "iovlen = 0;".
However, I cannot see why that is needed, so
I think the change is ok.

This revision is now accepted and ready to land.Apr 23 2025, 12:08 AM
Closed by commit rG5fa183f02845: mountd: use free_iovec for build_iovec cleanup (authored by brooks). · Explain WhyApr 25 2025, 3:58 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rG5fa183f02845: mountd: use free_iovec for build_iovec cleanup.

Revision Contents
Changeset List

PathSize
usr.sbin/
mountd/
27 lines

Diff 154058

View Options

usr.sbin/mountd/mountd.c

Loading...