riscv: Fix handling of interrupts during kernel page faults
ClosedPublic
Actions

Authored by markj on Fri, Apr 18, 8:35 PM.

Details

Reviewers

br
mhorne
jrtc27

Group Reviewers

riscv

Commits

rGdfbda7c53d67: riscv: Fix handling of interrupts during kernel page faults
rG0ca5e3dd1ad0: riscv: Fix handling of interrupts during kernel page faults

Summary

We were checking the wrong status bit when deciding whether to enable
interrupts.

Fixes: c226f193515c ("riscv: Permit spurious faults in kernel mode")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63582
Build 60466: arc lint + arc unit

Event Timeline

markj created this revision.Fri, Apr 18, 8:35 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Apr 18, 8:35 PM

markj requested review of this revision.Fri, Apr 18, 8:35 PM

Harbormaster completed remote builds in B63582: Diff 153889.Fri, Apr 18, 8:35 PM

Oh, yes, I failed to spot that in the review but this was clearly wrong and a no-op

This revision is now accepted and ready to land.Fri, Apr 18, 9:07 PM

Closed by commit rG0ca5e3dd1ad0: riscv: Fix handling of interrupts during kernel page faults (authored by markj). · Explain WhySat, Apr 19, 10:42 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG0ca5e3dd1ad0: riscv: Fix handling of interrupts during kernel page faults.

markj added a commit: rGdfbda7c53d67: riscv: Fix handling of interrupts during kernel page faults.Tue, Apr 29, 12:48 AM

Revision Contents
Changeset List

Path

Size

sys/

riscv/

trap.c

2 lines

Diff 153889

View Options

riscv: Fix handling of interrupts during kernel page faultsClosedPublicActions