Page MenuHomeFreeBSD

loader: Add loader_menu
ClosedPublic

Authored by manu on Mon, Apr 14, 6:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 3, 3:42 AM
Unknown Object (File)
Sat, May 3, 3:42 AM
Unknown Object (File)
Sat, May 3, 3:42 AM
Unknown Object (File)
Sat, May 3, 3:42 AM
Unknown Object (File)
Sat, May 3, 3:42 AM
Unknown Object (File)
Sat, Apr 26, 6:34 AM
Unknown Object (File)
Fri, Apr 25, 1:28 AM
Unknown Object (File)
Thu, Apr 17, 8:42 AM

Details

Reviewers
imp
kevans
Group Reviewers
Loader
Commits
rGa962800a09a4: loader: Add loader_menu
Summary

If set to 'none' then the menu isn't displayed.

Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 63493
Build 60377: arc lint + arc unit

Event Timeline

manu requested review of this revision.Mon, Apr 14, 6:40 AM

I haven't looked in-depth, but how is this different/better than beastie_disable=YES?

I haven't looked in-depth, but how is this different/better than beastie_disable=YES?

beastie_disable still prints something, the goal of the two reviews is to have nothing on the screen (and I'm working on auto positioning parts depending on which are enabled, so for example one can have the menu in the middle or just the orb in the middle of the screen).

Sorry for all the questions, just trying to figure out if I can clarify the docs somehow, or maybe even if it makes sense just to fix one of the other options, because we have a great deal of options which sound like they should do this already.

For the final what about, what about boot_mute?

Sorry for all the questions, just trying to figure out if I can clarify the docs somehow, or maybe even if it makes sense just to fix one of the other options, because we have a great deal of options which sound like they should do this already.

For the final what about, what about boot_mute?

If I re-use boot_mute (which for now just mute/show logo during kernel boot) this is POLA.
I though about using loader_mute but I like the idea of just having the orb/brand during loader so controlling each component looked better to me.

what do other values cause to happen? Why 'none' and not 'yes/no' like other similar things?

Strongly agree with boot_mute. that's absolutely the wrong thing to use. It's already confused in its meaning since vt and sc have different takes on it.
We should avoid adding any more fuz there as we try to shave that yak.

This revision is now accepted and ready to land.Mon, Apr 14, 3:39 PM
In D49820#1135943, @imp wrote:

what do other values cause to happen? Why 'none' and not 'yes/no' like other similar things?

Other value will show the menu, it's a bit confusing but this was to use the same terminology as loader_brand/loader_logo (Also one can imagine in the future making menu totally customizable and re-using this knob to choose the menu).

Strongly agree with boot_mute. that's absolutely the wrong thing to use. It's already confused in its meaning since vt and sc have different takes on it.
We should avoid adding any more fuz there as we try to shave that yak.

I haven't looked in-depth, but how is this different/better than beastie_disable=YES?

beastie_disable still prints something, the goal of the two reviews is to have nothing on the screen (and I'm working on auto positioning parts depending on which are enabled, so for example one can have the menu in the middle or just the orb in the middle of the screen).

Can you include that contrast in the commit message, please?

This revision was automatically updated to reflect the committed changes.