Merge the FreeBSD-specific implementation of osdep_uuidgen() with that
of Linux. While the latter is more complex, it lets us ensure that the
returned UUIDs are reproducible.
This mainly affects the UUID embedded in the GPT header.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 63427 Build 60311: arc lint + arc unit
Event Timeline
| usr.bin/mkimg/uuid.c | ||
|---|---|---|
| 62 | We could (also) check SOURCE_DATE_EPOCH here | |
| usr.bin/mkimg/uuid.c | ||
|---|---|---|
| 62 | There are random(3) calls below, which is why I didn't do that here, but mkimg wasn't seeding the PRNG so I believe they are effectively deterministic anyway (modulo random(3) implementation being the same). | |
Comment Actions
Remove SOURCE_DATE_EPOCH handling per some earlier discussions.
Just using a fixed timestamp for UUIDs is good enough.
| usr.bin/mkimg/mkimg.1 | ||
|---|---|---|
| 25 | ||
Comment Actions
Hmm. It was probably a mistake to do it this way. I should have added a timestamp option, like makefs has with -T. There is one other place I missed, in the VHD footer, where we need a timestamp, and since it's part of the image metadata, it's probably not ideal to hard-code a single value.
I'll post a patch which removes -R and instead adds an explicit timestamp option. Unfortunately, -T is already taken.