Tags

None

Referenced Files

	F156648785: D49689.id153215.diff
	Fri, May 15, 9:35 AM

	F156648773: D49689.id153215.diff
	Fri, May 15, 9:35 AM

	F156626542: D49689.id.diff
	Fri, May 15, 5:30 AM

	F156586785: D49689.id153291.diff
	Thu, May 14, 9:38 PM

	Unknown Object (File)
	Tue, May 12, 6:13 AM

	Unknown Object (File)
	Wed, Apr 29, 5:01 PM

	Unknown Object (File)
	Wed, Apr 29, 1:34 PM

	Unknown Object (File)
	Wed, Apr 29, 1:27 PM

View All Files

Subscribers

imp

Details

Reviewers

andrew
manu
phk

Commits

rG489489b4bc55: fdt: bump FDT_MEM_REGIONS to 64

Summary

The Snapdragon X1E / Lenovo T14s device tree has 47 reserved memory
regions. The reserved region parsing doesn't boundary check and will
just end up array bounds smashing, which leads to a reboot before
any console IO is written.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adrian created this revision.Apr 6 2025, 8:42 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 6 2025, 8:42 PM

adrian requested review of this revision.Apr 6 2025, 8:42 PM

Harbormaster completed remote builds in B63356: Diff 153215.Apr 6 2025, 8:43 PM

adrian added a parent revision: D49686: qcom_gcc: migrate to use sleep_clk directly.Apr 6 2025, 8:44 PM

adrian added reviewers: andrew, manu, phk.

adrian added a child revision: D49690: arm64: add the lenovo t14s snapdragon X1E device tree to the build list.

phk accepted this revision.Apr 7 2025, 4:55 AM

This revision is now accepted and ready to land.Apr 7 2025, 4:55 AM

manu accepted this revision.Apr 7 2025, 5:52 AM

oh added a subscriber: oh.Apr 7 2025, 9:09 AM

Closed by commit rG489489b4bc55: fdt: bump FDT_MEM_REGIONS to 64 (authored by adrian). · Explain WhyApr 8 2025, 3:48 AM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG489489b4bc55: fdt: bump FDT_MEM_REGIONS to 64.

fdt: bump FDT_MEM_REGIONS to 64
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 153291

sys/dev/fdt/fdt_common.h

fdt: bump FDT_MEM_REGIONS to 64ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 153291

sys/dev/fdt/fdt_common.h

fdt: bump FDT_MEM_REGIONS to 64
ClosedPublic
Actions

Revision Contents
Changeset List