Page MenuHomeFreeBSD

mount(8): Mention -o rw, polish, sync usage
ClosedPublic

Authored by ziaee on Apr 5 2025, 3:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 25, 1:06 AM
Unknown Object (File)
Tue, Jun 24, 5:26 PM
Unknown Object (File)
Tue, Jun 24, 1:50 PM
Unknown Object (File)
Mon, Jun 23, 9:45 PM
Unknown Object (File)
Sun, Jun 22, 6:23 PM
Unknown Object (File)
Sun, Jun 22, 6:23 AM
Unknown Object (File)
Sat, Jun 21, 12:14 PM
Unknown Object (File)
Tue, Jun 17, 8:14 AM

Details

Summary

+ license: tag spdx, remove dead hyphen
+ -t: fix linter errors, sync to program usage
+ -o ro: explain itself before explaining it's equivelance
+ -o rw: mention

MFC after: 1 week
Fixes: 70866c8dbdb6c (Fix synopsis of the -t option)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 63337
Build 60221: arc lint + arc unit

Event Timeline

ziaee requested review of this revision.Apr 5 2025, 3:38 AM
guest-patmaddox added inline comments.
sbin/mount/mount.8
277

(spelling)

Fix spelling error, thank you Pat!

It's still misspelled :) The correct spelling is "Equivalent" (I realize now that my inline comment / code suggestion did not come through the email so it may not have been obvious)

Fix spelling typo for real this time, thanks Pat!

This revision is now accepted and ready to land.Apr 17 2025, 5:07 AM

Reading it again, I think that a better subject line might be:

mount: improve usage message and polish man page descriptions

since you don't have to give the exact details in the subject. the details are messy and hard to nicely summarize in more detail than I've done. Your subject line could be read as documenting the -o rw,polish option (which syntactically is an option, but isn't a real thing).

Thank you! This is exactly what I'm excited about wanting to get better at!

Edit, phabricator will not let me update the commit message due to complaining about syntax, but I have changed to the title suggested by imp in my local tree.