Page MenuHomeFreeBSD

fdp/writing-style: Improve subsections
ClosedPublic

Authored by ziaee on Mar 29 2025, 5:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 1, 2:23 AM
Unknown Object (File)
Sat, Mar 28, 11:52 AM
Unknown Object (File)
Wed, Mar 25, 3:27 PM
Unknown Object (File)
Mon, Mar 23, 7:11 PM
Unknown Object (File)
Mon, Mar 23, 6:48 AM
Unknown Object (File)
Sun, Mar 22, 5:04 AM
Unknown Object (File)
Thu, Mar 19, 3:02 AM
Unknown Object (File)
Tue, Mar 17, 1:29 PM
Subscribers

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 63193
Build 60077: arc lint + arc unit

Event Timeline

ziaee requested review of this revision.Mar 29 2025, 5:18 PM
ziaee created this revision.

Hey @jpb_jimby.name , I tagged you to show how we do the PR association. You git commit -a to roll all your pending changes into a commit, and it opens up your preferred editor, and then you make a commit message trailer with PR:. That then goes and automatically updates the PR, and then the commit message title becomes the title of the review. HTH!

fernape added a subscriber: fernape.

Hey @jpb_jimby.name , I tagged you to show how we do the PR association. You git commit -a to roll all your pending changes into a commit, and it opens up your preferred editor, and then you make a commit message trailer with PR:. That then goes and automatically updates the PR, and then the commit message title becomes the title of the review. HTH!

I think it is best practice to do git add <file1> <file2> ... and then commit to avoid commiting unwanted changes.

This revision is now accepted and ready to land.Mar 30 2025, 12:28 PM

I do not understand why everyone says that, but would like to improve! Currently, I use alias gs=git show and alias ga=git commit -a --amend several times after to adjust my commit message and tweak little things (and of course still mistakes get past sometimes, but never the wrong files), so manually adding the files seems like a lot of misplaced extra work.

This revision was automatically updated to reflect the committed changes.