fdp/writing-style: Improve subsections

[ziaee]

Summary

PR: 267428

[ziaee]

Hey @jpb_jimby.name , I tagged you to show how we do the PR association. You git commit -a to roll all your pending changes into a commit, and it opens up your preferred editor, and then you make a commit message trailer with PR:. That then goes and automatically updates the PR, and then the commit message title becomes the title of the review. HTH!

[fernape]

In D49567#1130101, @ziaee wrote:

Hey @jpb_jimby.name , I tagged you to show how we do the PR association. You git commit -a to roll all your pending changes into a commit, and it opens up your preferred editor, and then you make a commit message trailer with PR:. That then goes and automatically updates the PR, and then the commit message title becomes the title of the review. HTH!

I think it is best practice to do git add <file1> <file2> ... and then commit to avoid commiting unwanted changes.

[ziaee]

I do not understand why everyone says that, but would like to improve! Currently, I use alias gs=git show and alias ga=git commit -a --amend several times after to adjust my commit message and tweak little things (and of course still mistakes get past sometimes, but never the wrong files), so manually adding the files seems like a lot of misplaced extra work.

[jpb_jimby.name]

Thanks for the tip!

[carlavilla]

Much better :)