Page MenuHomeFreeBSD

release/vm: fix setting NO_ROOT and WITHOUT_QEMU
ClosedPublic

Authored by brooks on Mar 27 2025, 11:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 24, 2:14 AM
Unknown Object (File)
Tue, Sep 23, 4:53 AM
Unknown Object (File)
Wed, Sep 17, 1:12 AM
Unknown Object (File)
Tue, Sep 16, 6:36 AM
Unknown Object (File)
Sun, Sep 14, 2:52 AM
Unknown Object (File)
Mon, Sep 8, 3:22 PM
Unknown Object (File)
Sun, Sep 7, 4:57 PM
Unknown Object (File)
Fri, Sep 5, 3:38 PM
Subscribers

Details

Summary

To support common shell patterns (test -n and -z) we want NO_ROOT and
WITHOUT_QEMU to be set and not empty of they are set in the Makefile.
Actually do this rather than making them always set (which propogates
to submakes run by mk-vmimage.sh).

Reported by: cperciva
Sponsored by: DARPA, AFRL

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 63165
Build 60049: arc lint + arc unit

Event Timeline

Looks good to me. Slight commit message nit, the issue here is actually .if defined(NO_ROOT) in Makefile logic rather than -n or -z in a shell script. But the same concept applies.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 27 2025, 11:53 PM
This revision was automatically updated to reflect the committed changes.