release/vm: fix setting NO_ROOT and WITHOUT_QEMU
ClosedPublic
Actions

Authored by brooks on Mar 27 2025, 11:24 PM.

Details

Reviewers

cperciva
emaste

Commits

rGe6e5cd297ab4: release/vm: fix setting NO_ROOT and WITHOUT_QEMU

Summary

To support common shell patterns (test -n and -z) we want NO_ROOT and
WITHOUT_QEMU to be set and not empty of they are set in the Makefile.
Actually do this rather than making them always set (which propogates
to submakes run by mk-vmimage.sh).

Reported by: cperciva
Sponsored by: DARPA, AFRL

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 63165
Build 60049: arc lint + arc unit

Event Timeline

brooks created this revision.Mar 27 2025, 11:24 PM

Herald added subscribers: jrtc27, imp. · View Herald TranscriptMar 27 2025, 11:24 PM

brooks requested review of this revision.Mar 27 2025, 11:24 PM

Harbormaster completed remote builds in B63165: Diff 152773.Mar 27 2025, 11:24 PM

Looks good to me. Slight commit message nit, the issue here is actually .if defined(NO_ROOT) in Makefile logic rather than -n or -z in a shell script. But the same concept applies.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 27 2025, 11:53 PM

Closed by commit rGe6e5cd297ab4: release/vm: fix setting NO_ROOT and WITHOUT_QEMU (authored by brooks). · Explain Why

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rGe6e5cd297ab4: release/vm: fix setting NO_ROOT and WITHOUT_QEMU.