Page MenuHomeFreeBSD
Differential D49476

scsi/da: Only send SYNC CACHE for devices with mode page 8
ClosedPublic
Actions

Authored by imp on Mar 23 2025, 9:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 2, 11:54 AM
Unknown Object (File)
Fri, Oct 2, 8:53 AM
Unknown Object (File)
Fri, Sep 25, 1:13 PM
Unknown Object (File)
Fri, Sep 25, 1:01 PM
Unknown Object (File)
Fri, Sep 25, 1:00 PM
Unknown Object (File)
Fri, Sep 25, 1:00 PM
Unknown Object (File)
Fri, Sep 25, 11:02 AM
Unknown Object (File)
Mon, Sep 21, 10:50 AM
View All Files
Subscribers
None

Details

Reviewers
ken
markj
mav
chs
Group Reviewers
cam
Commits
rGd5489f7d91ae: scsi/da: Only send SYNC CACHE for devices with mode page 8
Summary

Mode page 8 is the 'cache' mode page. It's used to control the cache,
if one is present, on a device. When it is absent, that's a very
strong hint that SYNCHRONIZED CACHE willl not be necessary. Set the
NO_SYNC_CACHE quirk for this situation.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 63083
Build 59967: arc lint + arc unit

Event Timeline

imp created this revision.Mar 23 2025, 9:51 PM
Herald added a reviewer: cam. · View Herald TranscriptMar 23 2025, 9:51 PM
imp requested review of this revision.Mar 23 2025, 9:51 PM
Harbormaster completed remote builds in B63083: Diff 152575.Mar 23 2025, 9:51 PM
imp added a parent revision: D49475: umass: Bring in small fix from NetBSD's umass.Mar 23 2025, 9:51 PM
imp added a child revision: D49477: usb: Make autoquirk code optional and opt out.
imp added reviewers: ken, markj, mav.Mar 24 2025, 1:01 AM
imp updated this revision to Diff 152599.Mar 24 2025, 3:18 AM

Mask the page number off, otherwise we'll reject valid pages with high bits set.

Harbormaster completed remote builds in B63092: Diff 152599.Mar 24 2025, 3:18 AM
imp added a reviewer: chs.Apr 2 2025, 8:06 PM
imp updated this revision to Diff 154873.May 5 2025, 4:04 PM

rebase

Harbormaster completed remote builds in B63906: Diff 154873.May 5 2025, 4:04 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 7 2025, 9:37 PM
Closed by commit rGd5489f7d91ae: scsi/da: Only send SYNC CACHE for devices with mode page 8 (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rGd5489f7d91ae: scsi/da: Only send SYNC CACHE for devices with mode page 8.

Revision Contents
Changeset List

PathSize
sys/
cam/
scsi/
244 lines

Diff 152575

View Options

sys/cam/scsi/scsi_da.c

Loading...