Page MenuHomeFreeBSD

socket: Check for a NULL ctloutput handler in the SO_SETFIB handler
ClosedPublic

Authored by markj on Mar 21 2025, 2:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 30, 8:44 AM
Unknown Object (File)
Wed, Jun 25, 8:02 AM
Unknown Object (File)
Tue, Jun 24, 11:48 PM
Unknown Object (File)
Tue, Jun 24, 11:39 PM
Unknown Object (File)
Tue, Jun 24, 5:29 AM
Unknown Object (File)
Sun, Jun 22, 11:42 AM
Unknown Object (File)
Fri, Jun 20, 11:41 PM
Unknown Object (File)
Sun, Jun 15, 3:06 PM
Subscribers

Details

Summary

Some protocols, e.g., ng_btsocket_l2cap_raw_protosw, do not have one.

Reported by: syzkaller
Fixes: caccbaef8e26 ("socket: Move SO_SETFIB handling to protocol layers")
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 63022
Build 59906: arc lint + arc unit

Event Timeline

markj requested review of this revision.Mar 21 2025, 2:08 PM

I would do it differently. In uipc_domain.c add pr_ctloutput_notsupp() and add it with NOTSUPP() macro to pr_init() in the same file.

This revision is now accepted and ready to land.Mar 24 2025, 6:34 AM