Differential D49366

net80211: correct IEEE80211_KEY_BITS
ClosedPublic
Actions

Authored by bz on Mar 14 2025, 11:24 PM.

Details

Reviewers

adrian

Group Reviewers

wireless

Commits

rG20f3d58fb8a6: net80211: correct IEEE80211_KEY_BITS
rG0461600deaa2: net80211: correct IEEE80211_KEY_BITS

Summary

Not only are a fair share of the bits missing, \5 and following were
also off-by-one. Correct that so we can use them instead of reading
hex numbers.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 62927
Build 59811: arc lint + arc unit

Event Timeline

bz created this revision.Mar 14 2025, 11:24 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptMar 14 2025, 11:24 PM

bz requested review of this revision.Mar 14 2025, 11:24 PM

Harbormaster completed remote builds in B62927: Diff 152285.Mar 14 2025, 11:24 PM

bz added a child revision: D49369: net80211: make use of IEEE80211_KEY_BITS for debug messages.Mar 15 2025, 10:27 PM

Anyone interested in cross-checking this to the bits define above? Otherwise I'll go ahead and push it tomorrow.

oh good catch!

This revision is now accepted and ready to land.Mar 17 2025, 10:09 PM

Closed by commit rG0461600deaa2: net80211: correct IEEE80211_KEY_BITS (authored by bz). · Explain WhyMar 18 2025, 9:22 AM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG0461600deaa2: net80211: correct IEEE80211_KEY_BITS.

bz added a commit: rG20f3d58fb8a6: net80211: correct IEEE80211_KEY_BITS.Apr 18 2025, 2:37 PM

Revision Contents
Changeset List

Path

Size

sys/

net80211/

ieee80211_crypto.h

4 lines

Diff 152285

View Options

sys/net80211/ieee80211_crypto.h

net80211: correct IEEE80211_KEY_BITSClosedPublicActions