Paths

Table of Contentst

Differential D49320

release/vm: partially support NO_ROOT
ClosedPublic
Actions

Authored by brooks on Mar 11 2025, 10:17 PM.

Tags

None

Referenced Files

	F137288145: D49320.id152161.diff
	Sat, Nov 22, 2:18 AM

	F137210986: D49320.id152181.diff
	Fri, Nov 21, 1:03 PM

	F137210829: D49320.id152161.diff
	Fri, Nov 21, 1:02 PM

	F137210643: D49320.id152187.diff
	Fri, Nov 21, 1:01 PM

	F137210642: D49320.id.diff
	Fri, Nov 21, 1:01 PM

	F137210602: D49320.id152195.diff
	Fri, Nov 21, 1:01 PM

	F137210380: D49320.id152156.diff
	Fri, Nov 21, 1:00 PM

	F137209613: D49320.diff
	Fri, Nov 21, 12:56 PM

View All 81 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rGc41ba99779d0: release/vm: partially support NO_ROOT

Summary

For images that don't require QEMU, support NO_ROOT. This entails:

Passing NO_ROOT down to mk-vmimage.sh (which sets it for installworld, etc)
Handling etcupdate bootstrapping
Adding assorted config file METALOG entries
Running makefs in the right directory and adding -D for dups

The main gap in NO_ROOT support is package installation.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Mar 11 2025, 10:17 PM

Herald added subscribers: jrtc27, imp. · View Herald TranscriptMar 11 2025, 10:17 PM

brooks requested review of this revision.Mar 11 2025, 10:17 PM

Harbormaster completed remote builds in B62871: Diff 152156.Mar 11 2025, 10:17 PM

brooks added a child revision: D49321: release/vm: force replacement of compressed images.Mar 11 2025, 10:17 PM

brooks added a parent revision: D49310: release/vm: add a WITHOUT_QEMU option.Mar 11 2025, 10:17 PM

jrtc27 added inline comments.Mar 11 2025, 10:24 PM

release/tools/vmimage.subr
71–78	`${NO_ROOT:+-N}` and drop the var?
211–212	Why the cd if you also use DESTDIR in sourcepath? (I can guess why the cd, but then should sourcepath not just be .[/METALOG]?)

Implement suggetions from @jrtc27

Use shell variable substitutions instead of temporaries
Use DESTDIR-relative paths in makefs calls

Harbormaster completed remote builds in B62876: Diff 152161.Mar 12 2025, 12:14 AM

brooks marked 2 inline comments as done.Mar 12 2025, 12:21 AM

Looks reasonable. Perhaps also add comments on cases that still need NO_ROOT support?

release/tools/vmimage.subr
72	Add a comment here?

This revision is now accepted and ready to land.Mar 12 2025, 12:46 PM

Add a comment about the etcupdate metalog bits
Require that both or neither of WITHOUT_QEMU and NO_ROOT be set

This revision now requires review to proceed.Mar 12 2025, 5:49 PM

Harbormaster completed remote builds in B62885: Diff 152181.Mar 12 2025, 5:49 PM

brooks edited the summary of this revision. (Show Details)Mar 12 2025, 5:49 PM

emaste accepted this revision.Mar 12 2025, 5:59 PM

This revision is now accepted and ready to land.Mar 12 2025, 5:59 PM

fix BASIC-CI images (missing files)
add some more abstraction to reduce the overall diff

This revision now requires review to proceed.Mar 12 2025, 7:43 PM

Harbormaster completed remote builds in B62888: Diff 152187.Mar 12 2025, 7:44 PM

emaste accepted this revision as: emaste.Mar 12 2025, 7:45 PM

This revision is now accepted and ready to land.Mar 12 2025, 7:45 PM

Closed by commit rGc41ba99779d0: release/vm: partially support NO_ROOT (authored by brooks). · Explain WhyMar 12 2025, 9:07 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rGc41ba99779d0: release/vm: partially support NO_ROOT.

Revision Contents
Changeset List

Path

Size

release/

5 lines

tools/

4 lines

33 lines

Diff 152195

release/Makefile.vm

Loading...

release/tools/basic-ci.conf

Loading...

release/tools/vmimage.subr

Loading...