Details

Reviewers

Group Reviewers

Commits

rG92d399a3be0e: release/vm: add a WITHOUT_QEMU option

Summary

This option disables trying to build a qemu-<target>-static and simply
doesn't do any of the operations that rely on it. At a glance, all
appear to be useful, but not essential to building simple images without
packages.

Disable all CLOUDWARE variants that require pkg when WITHOUT_QEMU is set
as this currently requires qemu support.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 62875
Build 59759: arc lint + arc unit

Event Timeline

brooks created this revision.Mar 10 2025, 6:21 PM

Herald added subscribers: jrtc27, imp. · View Herald TranscriptMar 10 2025, 6:21 PM

brooks requested review of this revision.Mar 10 2025, 6:21 PM

Harbormaster completed remote builds in B62857: Diff 152101.Mar 10 2025, 6:21 PM

Don't require WITHOUT_QEMU to have a value
Rebase

Harbormaster completed remote builds in B62870: Diff 152155.Mar 11 2025, 10:16 PM

brooks added a child revision: D49320: release/vm: partially support NO_ROOT.Mar 11 2025, 10:17 PM

Implement suggetions from @jrtc27

Use shell variable substitutions instead of temporaries
Use DESTDIR-relative paths in makefs calls

Harbormaster completed remote builds in B62874: Diff 152159.Mar 11 2025, 11:55 PM

In D49310#1124766, @brooks wrote:

Implement suggetions from @jrtc27

Use shell variable substitutions instead of temporaries

Use DESTDIR-relative paths in makefs calls

Sigh, somehow the fix applied to the wrong commit. Will reconstruct and update.

Restore to previous version

Harbormaster completed remote builds in B62875: Diff 152160.Mar 12 2025, 12:13 AM

emaste accepted this revision as: emaste.Mar 12 2025, 6:00 PM

This revision is now accepted and ready to land.Mar 12 2025, 6:00 PM

Closed by commit rG92d399a3be0e: release/vm: add a WITHOUT_QEMU option (authored by brooks). · Explain WhyMar 12 2025, 9:07 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG92d399a3be0e: release/vm: add a WITHOUT_QEMU option.