Differential D49270

mmc: Use bus_topo_lock and taskqueue_bus while adding/removing child devices
ClosedPublic
Actions

Authored by jhb on Mar 6 2025, 10:07 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jul 23, 8:44 AM

	Unknown Object (File)
	Thu, Jul 23, 7:17 AM

	Unknown Object (File)
	Wed, Jul 22, 2:00 PM

	Unknown Object (File)
	Sat, Jul 18, 4:26 PM

	Unknown Object (File)
	Sun, Jul 12, 4:24 AM

	Unknown Object (File)
	Sat, Jul 11, 12:42 AM

	Unknown Object (File)
	Fri, Jul 10, 3:55 AM

	Unknown Object (File)
	Mon, Jul 6, 9:12 PM

Subscribers

None

Details

Reviewers

imp
andrew
manu

Commits

rGee08e8455170: mmc: Use bus_topo_lock and taskqueue_bus while adding/removing child devices
rGc0bed9bd0bda: mmc: Use bus_topo_lock and taskqueue_bus while adding/removing child devices

Summary

Some drivers held regular mutexes across some new-bus calls, instead
depend on bus_topo_lock to protect the relevant softc members. This
also fixes the bus_topo_lock to be explicit in these drivers rather
than relying on the implicit Giant from taskqueue_swi_giant, and it
avoids calling sleepable routines like device_probe_and_attach from an
swi context.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62806
Build 59690: arc lint + arc unit

Event Timeline

jhb created this revision.Mar 6 2025, 10:07 PM

Herald added a reviewer: andrew. · View Herald TranscriptMar 6 2025, 10:07 PM

Herald added a reviewer: manu. · View Herald Transcript

jhb requested review of this revision.Mar 6 2025, 10:07 PM

Harbormaster completed remote builds in B62806: Diff 151982.Mar 6 2025, 10:07 PM

jhb added a parent revision: D49269: pcib: Use taskqueue_bus for hot-plug events instead of a private taskqueue.Mar 6 2025, 10:07 PM

jhb added a child revision: D49271: sdhci: Use bus_topo_lock and taskqueue_bus for hotplug events.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 10 2025, 5:36 PM

Closed by commit rGc0bed9bd0bda: mmc: Use bus_topo_lock and taskqueue_bus while adding/removing child devices (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGc0bed9bd0bda: mmc: Use bus_topo_lock and taskqueue_bus while adding/removing child devices.

jhb added a commit: rGee08e8455170: mmc: Use bus_topo_lock and taskqueue_bus while adding/removing child devices.Apr 29 2025, 6:31 PM

Revision Contents
Changeset List

Path

Size

sys/

arm/

allwinner/

11 lines

dev/

mmc/

host/

22 lines

mmc_fdt_helpers.c

10 lines

rtsx/

18 lines

Diff 151982

sys/arm/allwinner/aw_mmc.c

Loading...

sys/dev/mmc/host/dwmmc.c

Loading...

sys/dev/mmc/mmc_fdt_helpers.c

Loading...

sys/dev/rtsx/rtsx.c

Loading...