pci: Use a single variable for the offset of the power management registers
ClosedPublic
Actions

Authored by jhb on Mar 6 2025, 6:20 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Mar 14, 3:06 PM

	Unknown Object (File)
	Sun, Mar 8, 6:49 PM

	Unknown Object (File)
	Sat, Mar 7, 5:30 PM

	Unknown Object (File)
	Sat, Mar 7, 5:30 PM

	Unknown Object (File)
	Fri, Mar 6, 11:00 AM

	Unknown Object (File)
	Fri, Mar 6, 10:59 AM

	Unknown Object (File)
	Fri, Mar 6, 10:59 AM

	Unknown Object (File)
	Mon, Mar 2, 7:37 PM

View All 68 Files

Subscribers

None

Details

Reviewers

imp

Commits

rG86dd379d3ea2: pci: Use a single variable for the offset of the power management registers

Summary

This is the more typical pattern for other capability register sets,
and two of these variables weren't used.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62803
Build 59687: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Mar 6 2025, 6:20 PM

jhb created this revision.

Harbormaster completed remote builds in B62803: Diff 151976.Mar 6 2025, 6:20 PM

jhb added a parent revision: D49266: acpi_pci: Use pci_has_pm and pci_clear_pme.Mar 6 2025, 6:23 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 27 2025, 9:00 PM

Closed by commit rG86dd379d3ea2: pci: Use a single variable for the offset of the power management registers (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG86dd379d3ea2: pci: Use a single variable for the offset of the power management registers.

Revision Contents
Changeset List

Path

Size

sys/

dev/

pci/

pci.c

46 lines

pcivar.h

4 lines

Diff 151976

View Options

sys/dev/pci/pci.c