Page MenuHomeFreeBSD

*/*: Prepare removal of Uses=qca
ClosedPublic

Authored by fernape on Feb 21 2025, 7:14 AM.
Tags
None
Referenced Files
F115177923: D49093.diff
Mon, Apr 21, 4:22 AM
F115173397: D49093.diff
Mon, Apr 21, 3:34 AM
Unknown Object (File)
Thu, Apr 17, 2:44 AM
Unknown Object (File)
Mon, Apr 7, 4:21 PM
Unknown Object (File)
Sat, Apr 5, 12:21 AM
Unknown Object (File)
Mar 11 2025, 1:43 PM
Unknown Object (File)
Mar 10 2025, 3:57 PM
Unknown Object (File)
Mar 7 2025, 2:22 AM
Subscribers

Details

Summary

kde@ is in favor of removing Uses=qca that was initially introduced to help with
the migration from OpenSSL < 1.1 for FreeBSD 11.

Add the corresponding 'LIB_DEPENDS` on those ports still using this feature.

Building this ports requires building more than 580 ports. After several runs, I got that number down to 160, but there are quite a few that don't build in my not-so-beefy machine.
So I kindly request that maintainers check the correctness of this change :-)

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 62563
Build 59447: arc lint + arc unit

Event Timeline

fernape created this revision.
danfe requested changes to this revision.Feb 21 2025, 9:19 AM
danfe added inline comments.
net-im/psi/Makefile
14

I think you're using the wrong flavor here, it should be @qt5 (cf. USES below). I also don't see the need to bump port revision, presuming that existing USES=qca pulls exactly that library.

This revision now requires changes to proceed.Feb 21 2025, 9:19 AM

PORTREVSION bumps are not needed, as Alexey has already noticed, since nothing changes for packages. net-im/psi should depend on qt5 flavor, other ports look fine. I'd keep LIB_DEPENDS sorted where they were sorted, but it's not a big deal.

PORTREVSION bumps are not needed, as Alexey has already noticed, since nothing changes for packages. net-im/psi should depend on qt5 flavor, other ports look fine. I'd keep LIB_DEPENDS sorted where they were sorted, but it's not a big deal.

Should be done now.

net-im/psi/Makefile
14

Thanks for spotting this.

This revision is now accepted and ready to land.Feb 21 2025, 3:45 PM

Both QGIS ports related changes LGTM. Thanks!

I have just updated graphics/qgis and graphics/qgis-ltr to newer versions[1][2]. I also made the changes for qca at the same time.

Therefore, graphics/qgis and graphics/qgis-ltr are no longer affected by this review and should be removed before committing, thanks.

[1] https://cgit.freebsd.org/ports/commit/?id=ee9e39ceb1af729ac33854b5f3de652cb5ce0eca
[2] https://cgit.freebsd.org/ports/commit/?id=ed358aeb04b31f6659b3573a2e013e54c0959093

Sorry, but I did the same for net-im/qxmpp since I didn't see any movement since @rhurlin updated his ports. This is otherwise GTG.

Sorry, but I did the same for net-im/qxmpp since I didn't see any movement since @rhurlin updated his ports. This is otherwise GTG.

I'm waiting for @fluffy...

Sorry, but I did the same for net-im/qxmpp since I didn't see any movement since @rhurlin updated his ports. This is otherwise GTG.

I'm waiting for @fluffy...

For irc/quassel leave out the newline between BUILD_DEPENDS and LIB_DEPENDS. That's all that really needs to be done. The majority has approved.

This revision was automatically updated to reflect the committed changes.

Thank you all for the reviews.