Page MenuHomeFreeBSD
Differential D49030

net80211: crypto: ccmp: fix more hardware offload bits
ClosedPublic
Actions

Authored by bz on Feb 16 2025, 1:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 31, 6:50 PM
Unknown Object (File)
Thu, Oct 23, 3:25 PM
Unknown Object (File)
Thu, Oct 23, 3:24 PM
Unknown Object (File)
Thu, Oct 23, 3:24 PM
Unknown Object (File)
Thu, Oct 23, 6:46 AM
Unknown Object (File)
Wed, Oct 22, 4:41 PM
Unknown Object (File)
Mon, Oct 6, 5:28 AM
Unknown Object (File)
Sep 27 2025, 11:10 PM
View All 41 Files
Subscribers
adrian
glebius
imp
melifaro

Details

Reviewers
adrian
Group Reviewers
wireless
Commits
rGe8376bc284f1: net80211: crypto: ccmp: fix more hardware offload bits
rG3afc0bfecb1a: net80211: crypto: ccmp: fix more hardware offload bits
Summary

Add the missing IEEE80211_RX_F_DECRYPTED and IEEE80211_RX_F_MMIC_STRIP
(really just MIC_STRIP) checks to make hwaccel offload work.
This makes rtw8x drivers pass RX packets again at least with LinuxKPI
HW_CRYPTO support.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Test Plan

Note: the (fixed) HW_CRYPTO support has not landed in LinuxKPI
as it'll not work without this (and the previous) change.

Diff Detail

Repository
rG FreeBSD src repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 62475
Build 59359: arc lint + arc unit

Event Timeline

bz created this revision.Feb 16 2025, 1:30 AM
Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptFeb 16 2025, 1:30 AM
bz requested review of this revision.Feb 16 2025, 1:30 AM
Harbormaster completed remote builds in B62475: Diff 151090.Feb 16 2025, 1:30 AM
adrian accepted this revision.Feb 16 2025, 1:44 AM
adrian added a subscriber: adrian.
adrian added inline comments.
sys/net80211/ieee80211_crypto_ccmp.c
679

no need for braces! :)

This revision is now accepted and ready to land.Feb 16 2025, 1:44 AM
bz marked an inline comment as done.Feb 16 2025, 1:50 AM
bz added inline comments.
sys/net80211/ieee80211_crypto_ccmp.c
679

:) Shall I remove then here and above on the return statement to stay in file-style or should we follow-style.9 more and more in net80211?

adrian added inline comments.Feb 16 2025, 1:56 AM
sys/net80211/ieee80211_crypto_ccmp.c
679

only in the new code, we should do some separate diffs later for style cleanup but after we land all of our branch work. :-)

Closed by commit rG3afc0bfecb1a: net80211: crypto: ccmp: fix more hardware offload bits (authored by bz). · Explain WhyFeb 16 2025, 8:24 PM
This revision was automatically updated to reflect the committed changes.
bz marked an inline comment as done.
bz added a commit: rG3afc0bfecb1a: net80211: crypto: ccmp: fix more hardware offload bits.
bz added a commit: rGe8376bc284f1: net80211: crypto: ccmp: fix more hardware offload bits.Feb 24 2025, 8:28 PM

Revision Contents
Changeset List

PathSize
sys/
net80211/
13 lines

Diff 151090

View Options

sys/net80211/ieee80211_crypto_ccmp.c

Loading...