net80211: crypto: enhance comment about IEEE80211_RX_F_MMIC_STRIP
ClosedPublic
Actions

Authored by bz on Feb 12 2025, 11:34 PM.

Details

Reviewers

Group Reviewers

Commits

rG3b84a5133a57: net80211: crypto: enhance comment about IEEE80211_RX_F_MMIC_STRIP
rGd688c20395a9: net80211: crypto: enhance comment about IEEE80211_RX_F_MMIC_STRIP

Summary

net80211 crypto currently re-uses the M[ichael]MIC flag for MIC as well
at least in CCMP. This is a bit confusing so at least try to improve
the comment that it becomes more obvious.
In the long-term we may want to just add a MIC flag as well?

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Feb 12 2025, 11:34 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptFeb 12 2025, 11:34 PM

bz requested review of this revision.Feb 12 2025, 11:34 PM

Harbormaster completed remote builds in B62409: Diff 150933.Feb 12 2025, 11:34 PM

Yeah that's a good call, let's see what we can do with the current drivers!

adrian accepted this revision.Feb 13 2025, 1:08 AM

This revision is now accepted and ready to land.Feb 13 2025, 1:08 AM

Closed by commit rGd688c20395a9: net80211: crypto: enhance comment about IEEE80211_RX_F_MMIC_STRIP (authored by bz). · Explain WhyFeb 15 2025, 3:52 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rGd688c20395a9: net80211: crypto: enhance comment about IEEE80211_RX_F_MMIC_STRIP.

bz added a commit: rG3b84a5133a57: net80211: crypto: enhance comment about IEEE80211_RX_F_MMIC_STRIP.Feb 24 2025, 8:28 PM

Revision Contents
Changeset List

Path

Size

sys/

net80211/

_ieee80211.h

2 lines

Diff 151078

View Options

net80211: crypto: enhance comment about IEEE80211_RX_F_MMIC_STRIPClosedPublicActions