Page MenuHomeFreeBSD
Differential D48816

arm64: add missing feature identification to align with ARMv8.9
ClosedPublic
Actions

Authored by harry.moulton_arm.com on Feb 3 2025, 4:51 PM.
Tags
None
Referenced Files
F150951869: D48816.id150960.diff
Sun, Apr 5, 4:01 AM
Unknown Object (File)
Wed, Apr 1, 7:09 PM
Unknown Object (File)
Sat, Mar 28, 4:47 AM
Unknown Object (File)
Thu, Mar 26, 9:28 AM
Unknown Object (File)
Thu, Mar 26, 9:23 AM
Unknown Object (File)
Mon, Mar 23, 2:08 PM
Unknown Object (File)
Sun, Mar 22, 8:23 PM
Unknown Object (File)
Thu, Mar 19, 8:06 PM
View All 94 Files
Subscribers
emaste
imp

Details

Reviewers
andrew
manu
Group Reviewers
arm64
Commits
rG76c38c2f2e02: arm64: add missing feature identification to align with ARMv8.9
Summary

Feature bit definitions in armreg.h have been updated to align with
ARMv8.9. This change implements those updates in identcpu.c.

Sponsored by: Arm Ltd
Signed-off-by: Harry Moulton <harry.moulton@arm.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62423
Build 59307: arc lint + arc unit

Event Timeline

harry.moulton_arm.com created this revision.Feb 3 2025, 4:51 PM
Herald added a reviewer: manu. · View Herald TranscriptFeb 3 2025, 4:51 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
harry.moulton_arm.com requested review of this revision.Feb 3 2025, 4:51 PM
harry.moulton_arm.com added a parent revision: D48815: arm64: update and align armreg.h with ARMv8.9 features.
Harbormaster completed remote builds in B62225: Diff 150414.Feb 3 2025, 4:51 PM
andrew accepted this revision.Feb 13 2025, 12:32 PM

LGTM, other than any changes needed if macro names are changed in D48815

sys/arm64/arm64/identcpu.c
1292–1294

We should check for the other "not implemented" value here

This revision is now accepted and ready to land.Feb 13 2025, 12:32 PM
harry.moulton_arm.com updated this revision to Diff 150960.Feb 13 2025, 2:10 PM

Small changes as a result of comments on parent change

This revision now requires review to proceed.Feb 13 2025, 2:10 PM
Harbormaster completed remote builds in B62423: Diff 150960.Feb 13 2025, 2:10 PM
andrew accepted this revision.Feb 13 2025, 6:17 PM
This revision is now accepted and ready to land.Feb 13 2025, 6:17 PM
Closed by commit rG76c38c2f2e02: arm64: add missing feature identification to align with ARMv8.9 (authored by harry.moulton_arm.com, committed by andrew). · Explain WhyFeb 17 2025, 4:37 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG76c38c2f2e02: arm64: add missing feature identification to align with ARMv8.9.

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
159 lines

Diff 150960

View Options

sys/arm64/arm64/identcpu.c

Loading...