iichid(4): Read wMaxInputLength bytes over I2C even if we discards data
ClosedPublic
Actions

Authored by wulf on Feb 12 2025, 7:01 AM.

Details

Reviewers

Commits

rG3bd684f0aafe: iichid(4): Read wMaxInputLength bytes over I2C even if we discards data
rG548d3aa856a9: iichid(4): Read wMaxInputLength bytes over I2C even if we discards data

Summary

For some devices e.g. ITE5570 it is not enough to read HID-over-I2C
input length header of RESET command response to acknowledge interrupt.
Do a full-size read to avoid interrupt storm.

Sponsored by: Future Crew LLC
MFC after: 2 month

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62385
Build 59269: arc lint + arc unit

Event Timeline

wulf created this revision.Feb 12 2025, 7:01 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 12 2025, 7:01 AM

wulf requested review of this revision.Feb 12 2025, 7:01 AM

Harbormaster completed remote builds in B62385: Diff 150884.Feb 12 2025, 7:01 AM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 7 2025, 6:28 AM

Closed by commit rG548d3aa856a9: iichid(4): Read wMaxInputLength bytes over I2C even if we discards data (authored by wulf). · Explain Why

This revision was automatically updated to reflect the committed changes.

wulf added a commit: rG548d3aa856a9: iichid(4): Read wMaxInputLength bytes over I2C even if we discards data.

wulf added a commit: rG3bd684f0aafe: iichid(4): Read wMaxInputLength bytes over I2C even if we discards data.May 15 2025, 6:18 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

iicbus/

iichid.c

47 lines

Diff 150884

View Options

iichid(4): Read wMaxInputLength bytes over I2C even if we discards dataClosedPublicActions