Page MenuHomeFreeBSD
Differential D48808

riscv vmm: various fixes in APLIC
ClosedPublic
Actions

Authored by br on Feb 3 2025, 12:14 PM.
Tags
None
Referenced Files
F136325039: D48808.id150410.diff
Mon, Nov 17, 5:48 AM
F136322153: D48808.id150410.diff
Mon, Nov 17, 5:25 AM
Unknown Object (File)
Sun, Nov 16, 6:25 PM
Unknown Object (File)
Sun, Nov 16, 4:28 PM
Unknown Object (File)
Sun, Nov 16, 3:12 PM
Unknown Object (File)
Fri, Nov 7, 4:43 AM
Unknown Object (File)
Tue, Nov 4, 3:56 PM
Unknown Object (File)
Tue, Nov 4, 2:30 AM
View All 80 Files
Subscribers
imp
riscv

Details

Reviewers
jrtc27
markj
Commits
rGae65d59d4b8c: riscv vmm: various fixes in APLIC.
Summary
  • Implement level-sensitive interrupts
  • Disable up to 32 interrupts by a single query (CLRIE register handling)
  • Implement reading from DOMAINCFG

This is a minimal set of changes needed to boot Linux guest.

More work TODO to handle other APLIC registers read/write.

Test Plan

Linux booting in 0.48s with this. FreeBSD also speeds up for some reason

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br created this revision.Feb 3 2025, 12:14 PM
Herald added a subscriber: riscv. · View Herald TranscriptFeb 3 2025, 12:14 PM
br requested review of this revision.Feb 3 2025, 12:14 PM
markj added inline comments.Feb 3 2025, 2:58 PM
sys/riscv/vmm/vmm_aplic.c
184
186

Do you want to check the return value here?

306

Why isn't the mutex required here?

br updated this revision to Diff 150410.Feb 3 2025, 4:28 PM

Add spinlock around DOMAINCFG acccess.

sys/riscv/vmm/vmm_aplic.c
186

Do you want to check the return value here?

from the spec the write is ignored if value written is not an active interrupt source number in the domain
https://github.com/riscv/riscv-aia/releases/download/0.2-draft.24/riscv-interrupts-024.pdf

306

Indeed. Added!

markj added inline comments.Feb 3 2025, 6:23 PM
sys/riscv/vmm/vmm_aplic.c
158

Why not just

if ((irq->sourcecfg & SOURCECFG_SM_M) != SOURCECFG_SM_INACTIVE) {
    if (enabled)
        ...
}

?

184

This change is required to avoid UB.

186

This would be useful to mention in a comment, along with a (void) cast for the aplic_set_enabled() call.

br updated this revision to Diff 150435.Feb 3 2025, 8:44 PM

Address @markj comments. Thanks, Mark!

This revision was not accepted when it landed; it landed in state Needs Review.Feb 5 2025, 9:35 AM
Closed by commit rGae65d59d4b8c: riscv vmm: various fixes in APLIC. (authored by br). · Explain Why
This revision was automatically updated to reflect the committed changes.
br added a commit: rGae65d59d4b8c: riscv vmm: various fixes in APLIC..
Herald added a subscriber: imp. · View Herald TranscriptFeb 5 2025, 9:35 AM

Revision Contents
Changeset List

PathSize
sys/
riscv/
vmm/
79 lines

Diff 150410

View Options

sys/riscv/vmm/vmm_aplic.c

Loading...