Page MenuHomeFreeBSD
Differential D48730

mixer(3): Do not skip devices with no volume control
AcceptedPublic
Actions

Authored by christos on Thu, Jan 30, 5:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 5, 5:13 PM
Unknown Object (File)
Mon, Feb 3, 5:56 PM
Unknown Object (File)
Sun, Feb 2, 8:42 PM
Unknown Object (File)
Sun, Feb 2, 3:00 PM
Unknown Object (File)
Sun, Feb 2, 10:22 AM
Unknown Object (File)
Sat, Feb 1, 6:12 AM
Unknown Object (File)
Fri, Jan 31, 1:57 PM
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Summary

Some devices might not have a software volume control, but still be
able to be set as recording sources.

PR: 279787
Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62151
Build 59035: arc lint + arc unit

Event Timeline

christos created this revision.Thu, Jan 30, 5:57 PM
Herald added a subscriber: imp. · View Herald TranscriptThu, Jan 30, 5:57 PM
christos requested review of this revision.Thu, Jan 30, 5:57 PM
Harbormaster completed remote builds in B62151: Diff 150209.Thu, Jan 30, 5:57 PM
christos retitled this revision from mixer(3): Do not skip recording-only devices to mixer(3): Do not skip devices with no volume control.Sat, Feb 1, 11:08 AM
christos edited the summary of this revision. (Show Details)
christos added a comment.Sat, Feb 1, 1:48 PM

Related discussion in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279787. The issue is solved with this patch.

emaste accepted this revision.Mon, Feb 3, 12:21 PM

Thanks for updating the title, I was confused by this originally

lib/libmixer/mixer.c
123

Probably worth a comment here explaining why we allow failure. Or maybe if (_mixer_readvol(dp) < 0 && MIX_ISDEV(m, i))?

This revision is now accepted and ready to land.Mon, Feb 3, 12:21 PM
christos updated this revision to Diff 150404.Mon, Feb 3, 1:25 PM
christos marked an inline comment as done.

Address Ed's comment.

This revision now requires review to proceed.Mon, Feb 3, 1:25 PM
Harbormaster completed remote builds in B62220: Diff 150404.Mon, Feb 3, 1:25 PM
emaste accepted this revision.Mon, Feb 3, 2:47 PM

Ah yes, that's even better

This revision is now accepted and ready to land.Mon, Feb 3, 2:47 PM

Revision Contents
Changeset List

PathSize
lib/
libmixer/
5 lines

Diff 150209

View Options

lib/libmixer/mixer.c

Loading...