Page MenuHomeFreeBSD
Differential D48730

mixer(3): Do not skip devices with no volume control
ClosedPublic
Actions

Authored by christos on Jan 30 2025, 5:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 2, 11:32 PM
Unknown Object (File)
Fri, Oct 31, 10:33 AM
Unknown Object (File)
Fri, Oct 31, 5:55 AM
Unknown Object (File)
Thu, Oct 30, 10:21 PM
Unknown Object (File)
Sun, Oct 19, 11:31 PM
Unknown Object (File)
Sep 26 2025, 1:53 PM
Unknown Object (File)
Sep 24 2025, 3:27 AM
Unknown Object (File)
Sep 16 2025, 3:23 AM
View All 65 Files
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Commits
rG311b84540e73: mixer(3): Do not skip devices with no volume control
rGf121de8fbcbc: mixer(3): Do not skip devices with no volume control
Summary

Some devices might not have a software volume control, but still be
able to be set as recording sources.

PR: 279787
Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62220
Build 59104: arc lint + arc unit

Event Timeline

christos created this revision.Jan 30 2025, 5:57 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 30 2025, 5:57 PM
christos requested review of this revision.Jan 30 2025, 5:57 PM
Harbormaster completed remote builds in B62151: Diff 150209.Jan 30 2025, 5:57 PM
christos retitled this revision from mixer(3): Do not skip recording-only devices to mixer(3): Do not skip devices with no volume control.Feb 1 2025, 11:08 AM
christos edited the summary of this revision. (Show Details)
christos added a comment.Feb 1 2025, 1:48 PM

Related discussion in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279787. The issue is solved with this patch.

emaste accepted this revision.Feb 3 2025, 12:21 PM

Thanks for updating the title, I was confused by this originally

lib/libmixer/mixer.c
124

Probably worth a comment here explaining why we allow failure. Or maybe if (_mixer_readvol(dp) < 0 && MIX_ISDEV(m, i))?

This revision is now accepted and ready to land.Feb 3 2025, 12:21 PM
christos updated this revision to Diff 150404.Feb 3 2025, 1:25 PM
christos marked an inline comment as done.

Address Ed's comment.

This revision now requires review to proceed.Feb 3 2025, 1:25 PM
Harbormaster completed remote builds in B62220: Diff 150404.Feb 3 2025, 1:25 PM
emaste accepted this revision.Feb 3 2025, 2:47 PM

Ah yes, that's even better

This revision is now accepted and ready to land.Feb 3 2025, 2:47 PM
Closed by commit rGf121de8fbcbc: mixer(3): Do not skip devices with no volume control (authored by christos). · Explain WhyFeb 25 2025, 11:49 AM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rGf121de8fbcbc: mixer(3): Do not skip devices with no volume control.
christos added a commit: rG311b84540e73: mixer(3): Do not skip devices with no volume control.Mar 4 2025, 3:47 PM

Revision Contents
Changeset List

PathSize
lib/
libmixer/
4 lines

Diff 150404

View Options

lib/libmixer/mixer.c

Loading...