Differential D48466

amd64/fpu: Track supervisor state XSAVE components
ClosedPublic
Actions

Authored by bnovkov on Jan 15 2025, 5:10 PM.

Tags

None

Referenced Files

	F170944229: D48466.diff
	Mon, Sep 7, 6:48 PM

	Unknown Object (File)
	Sun, Sep 6, 9:24 AM

	Unknown Object (File)
	Thu, Aug 27, 4:57 PM

	Unknown Object (File)
	Wed, Aug 12, 12:47 PM

	Unknown Object (File)
	Wed, Aug 12, 3:13 AM

	Unknown Object (File)
	Aug 6 2026, 10:46 PM

	Unknown Object (File)
	Aug 6 2026, 10:46 PM

	Unknown Object (File)
	Aug 4 2026, 8:37 AM

Subscribers

Details

Reviewers

Commits

rGb9951017bab3: amd64/fpu: Track supervisor state XSAVE components

Summary

The amd64/fpu.c xsave_* routines track supported XSAVE components and
features. However, they only track supported user state components, and
there is currently no way for a consumer to check whether the CPU
supports a supervisor state component. Fix this by saving the supported
supervisor state components, enumerated by CPUID function 0DH,
sub-function 1, in a separate mask.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bnovkov created this revision.Jan 15 2025, 5:10 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 15 2025, 5:10 PM

bnovkov requested review of this revision.Jan 15 2025, 5:10 PM

Harbormaster completed remote builds in B61735: Diff 149295.Jan 15 2025, 5:10 PM

kib accepted this revision.Jan 17 2025, 11:35 PM

This revision is now accepted and ready to land.Jan 17 2025, 11:35 PM

kib added inline comments.Jan 17 2025, 11:38 PM

sys/amd64/amd64/fpu.c
427	At least for me it is cleaner

bnovkov added inline comments.Jan 22 2025, 12:57 PM

sys/amd64/amd64/fpu.c
427	I agree, I'll change this in the commit.

Closed by commit rGb9951017bab3: amd64/fpu: Track supervisor state XSAVE components (authored by bnovkov). · Explain WhyJan 22 2025, 12:59 PM

This revision was automatically updated to reflect the committed changes.

bnovkov added a commit: rGb9951017bab3: amd64/fpu: Track supervisor state XSAVE components.

bnovkov mentioned this in D46397: amd64: Intel Processor Trace support.Jan 22 2025, 1:05 PM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

amd64/

38 lines

x86/

include/

5 lines

Diff 149704

sys/amd64/amd64/fpu.c

Loading...

sys/x86/include/fpu.h

Loading...