riscv: Add driver for the cvitek reset controller
ClosedPublic
Actions

Authored by bnovkov on Jan 20 2025, 6:31 PM.

Details

Reviewers

br
imp

Commits

rG25b9b0b6bec9: riscv: Add driver for cvitek reset controller

Summary

This patch adds support for the cvitek reset controller.
This controller is present on the Milk-V riscv SoCs. The controller is
currently used by the if_dwc driver.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

bnovkov created this revision.Jan 20 2025, 6:31 PM

Herald added subscribers: riscv, imp. · View Herald TranscriptJan 20 2025, 6:31 PM

bnovkov requested review of this revision.Jan 20 2025, 6:31 PM

bnovkov added a child revision: D48530: dwc: Add support for the cvitek ethernet controller.

imp accepted this revision.Jan 20 2025, 6:34 PM

imp added inline comments.

sys/riscv/cvitek/cvitek_reset.c
64	If we use a table, then we can make this a module that's automatically loaded by the loader when it finds it in the FDT. Though if it's not a module, this is fine for now.

This revision is now accepted and ready to land.Jan 20 2025, 6:34 PM

jrtc27 added a subscriber: jrtc27.Jan 20 2025, 6:43 PM

jrtc27 added inline comments.

sys/riscv/cvitek/cvitek_reset.c
82	Uh, who knows what this is going to pick up... surely there's a phandle reference? That's how this normally works... that or it's a child of the syscon.
103–104	By definition these are both just 32? Don't see what benefit the calculation gives when it's already hard-coded in the type name.

Address @jrtc27 's comments.

This revision now requires review to proceed.Jan 21 2025, 7:09 PM

bnovkov added inline comments.Jan 21 2025, 7:09 PM

sys/riscv/cvitek/cvitek_reset.c
64	It is not a module for now, but I'll bear this in mind, thanks!
82	yeah, this was an issue in other places as well, I've rearranged the dts to include a syscon phandle and updated the code accordingly.
103–104	Right, unnecessary, replaced it with a constant.