pkg: Fix Coverity warnings
ClosedPublic
Actions

Authored by markj on Jan 16 2025, 3:12 PM.

Tags

None

Referenced Files

	F153056344: D48484.diff
	Sat, Apr 18, 9:26 PM

	Unknown Object (File)
	Wed, Apr 15, 7:13 AM

	Unknown Object (File)
	Sun, Apr 12, 10:58 AM

	Unknown Object (File)
	Fri, Apr 3, 4:41 PM

	Unknown Object (File)
	Thu, Apr 2, 4:40 PM

	Unknown Object (File)
	Thu, Mar 26, 4:40 PM

	Unknown Object (File)
	Mar 17 2026, 3:15 AM

	Unknown Object (File)
	Feb 27 2026, 8:32 PM

View All 69 Files

Subscribers

imp

Details

Reviewers

bapt
bdrewery

Summary

Fix allocation size in config_get_repositories().
Fix a memory leak in read_conf_file().
Avoid a null pointer dereference in an error path in verify_pubsignature().

Fixes: e3b4a51580fc ("pkg(7): expand VERSION_MAJOR, VERSION_MINOR, RELEASE and OSNAME")
Fixes: dc4581589a32 ("pkg: clean support for repositories")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61765
Build 58649: arc lint + arc unit

Event Timeline

markj created this revision.Jan 16 2025, 3:12 PM

Herald added a reviewer: bdrewery. · View Herald TranscriptJan 16 2025, 3:12 PM

Herald added a subscriber: imp. · View Herald Transcript

markj requested review of this revision.Jan 16 2025, 3:12 PM

Harbormaster completed remote builds in B61765: Diff 149343.Jan 16 2025, 3:12 PM

bapt accepted this revision.Jan 16 2025, 3:39 PM

This revision is now accepted and ready to land.Jan 16 2025, 3:39 PM

Committed in https://cgit.freebsd.org/src/commit/?id=c1557708f1fae1bb9c8e23e3bbb2aa2b055e1211, I forgot to tag the review.

Revision Contents
Changeset List

Path

Size

usr.sbin/

pkg/

config.c

14 lines

pkg.c

2 lines

Diff 149343

View Options

usr.sbin/pkg/config.c