Paths

Table of Contentst

Differential D48035

sound: Remove macro magic from pcm/feeder_matrix.c
ClosedPublic
Actions

Authored by christos on Dec 11 2024, 4:49 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jan 15, 8:15 AM

	Unknown Object (File)
	Tue, Jan 13, 4:27 AM

	Unknown Object (File)
	Tue, Jan 13, 1:51 AM

	Unknown Object (File)
	Tue, Jan 13, 1:51 AM

	Unknown Object (File)
	Mon, Jan 12, 12:58 PM

	Unknown Object (File)
	Sat, Jan 10, 4:25 PM

	Unknown Object (File)
	Thu, Jan 8, 2:55 PM

	Unknown Object (File)
	Tue, Jan 6, 10:56 PM

Subscribers

Details

Reviewers

markj
emaste
dev_submerge.ch

Commits

rGa25f84cf0910: sound: Remove macro magic from pcm/feeder_matrix.c
rGac24c9da8bb7: sound: Remove macro magic from pcm/feeder_matrix.c

Summary

Turn the FEEDMATRIX_DECLARE macro into a single inline function
(feed_matrix_apply()). There is no reason to have this as a macro, it
only complicated the code. An advantage of this patch is that, because
we no longer call the functions created by the macro through function
pointers (apply field of feed_matrix_info), we can call
feed_matrix_apply() directly in feed_matrix_feed().

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61091
Build 57975: arc lint + arc unit

Event Timeline

christos created this revision.Dec 11 2024, 4:49 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 11 2024, 4:49 PM

christos requested review of this revision.Dec 11 2024, 4:49 PM

Harbormaster completed remote builds in B61091: Diff 147823.Dec 11 2024, 4:49 PM

christos added a parent revision: D48034: sound: Cache bps in pcm/feeder_eq.c.Dec 11 2024, 4:49 PM

christos added a child revision: D48036: sound: Remove feed_matrix_apply_generic().

Same as D48032, you may want to call your function with literal format parameters, for performance reasons.

christos mentioned this in D48036: sound: Remove feed_matrix_apply_generic().Dec 15 2024, 10:51 PM

Address Florian's comment.

Harbormaster completed remote builds in B61268: Diff 148255.Dec 19 2024, 6:12 PM

Bump.

markj added inline comments.Dec 29 2024, 8:34 PM

sys/dev/sound/pcm/feeder_matrix.c
443	Why can't this entire switch statement just be `feed_matrix_apply(info, src, dst, j, info->fmt);`?

christos added inline comments.Dec 29 2024, 8:37 PM

sys/dev/sound/pcm/feeder_matrix.c
443	There is related discussion in D48032

Mark fmt argument as const.

Harbormaster completed remote builds in B61568: Diff 148915.Jan 7 2025, 8:54 PM

christos added a parent revision: D48421: sound: Turn clamp macros into a function.Jan 10 2025, 6:40 PM

Rebase on top of D48421.

Harbormaster completed remote builds in B61654: Diff 149084.Jan 10 2025, 6:42 PM

christos removed a parent revision: D48034: sound: Cache bps in pcm/feeder_eq.c.Jan 10 2025, 6:46 PM

Clamp accum, not v, as in the original code.

Harbormaster completed remote builds in B61692: Diff 149173.Jan 13 2025, 1:23 PM

Bump.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 10 2025, 8:22 PM

Closed by commit rGac24c9da8bb7: sound: Remove macro magic from pcm/feeder_matrix.c (authored by christos). · Explain Why

This revision was automatically updated to reflect the committed changes.

christos added a commit: rGac24c9da8bb7: sound: Remove macro magic from pcm/feeder_matrix.c.

christos added a commit: rGa25f84cf0910: sound: Remove macro magic from pcm/feeder_matrix.c.Mar 17 2025, 6:38 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

feeder_matrix.c

184 lines

Diff 147823

sys/dev/sound/pcm/feeder_matrix.c

Loading...