Add DEV_XENTIMER option
Needs RevisionPublic
Actions

Authored by kvinupriya_gmail.com on Dec 10 2024, 11:30 PM.

Details

Reviewers

Summary

Check for DEV_XENTIMER in pv.c as xen_timer.c code that implements
the xen_clock_init is under "options xentimer" in the files file.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61078
Build 57962: arc lint + arc unit

Event Timeline

kvinupriya_gmail.com created this revision.Dec 10 2024, 11:30 PM

Herald added subscribers: ehem_freebsd_m5p.com, imp. · View Herald TranscriptDec 10 2024, 11:30 PM

kvinupriya_gmail.com requested review of this revision.Dec 10 2024, 11:30 PM

Harbormaster completed remote builds in B61078: Diff 147801.Dec 10 2024, 11:30 PM

Looks reasonable to me. Though the option is primarily to allow removing the timer on ARM/RISC-V (where it doesn't presently work). I'm unsure whether it is possible to avoid on x86.

royger requested changes to this revision.Dec 11 2024, 7:57 AM

royger added inline comments.

sys/x86/xen/pv.c
111	Won't this lead to a call into NULL when booted as Xen PVH guest but without DEV_XENTIMER enabled? See `clock_init()`. You need an else branch here to define it to the native function (`native_clock_source_init()`), or otherwise patch the callers to only call early_clock_source_init if != NULL.