linuxkpi: Fix a lock leak in lkpi_sta_scan_to_auth()
ClosedPublic
Actions

Authored by markj on Dec 6 2024, 9:33 PM.

Details

Reviewers

Commits

rG2a6c77b343f6: linuxkpi: Fix a lock leak in lkpi_sta_scan_to_auth()
rG926905796749: linuxkpi: Fix a lock leak in lkpi_sta_scan_to_auth()

Summary

PR: 283015
Fixes: 0936c648ad0e ("LinuxKPI: 802.11: update the ni/lsta reference cycle")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60990
Build 57874: arc lint + arc unit

Event Timeline

markj created this revision.Dec 6 2024, 9:33 PM

Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptDec 6 2024, 9:33 PM

markj requested review of this revision.Dec 6 2024, 9:33 PM

Harbormaster completed remote builds in B60989: Diff 147617.Dec 6 2024, 9:33 PM

emaste added inline comments.Dec 6 2024, 9:51 PM

sys/compat/linuxkpi/common/src/linux_80211.c
1190	what is the lock lifecycle of this one?

Plug a reference count leak as well.

Harbormaster completed remote builds in B60990: Diff 147622.Dec 6 2024, 9:57 PM

markj marked an inline comment as done.Dec 6 2024, 9:59 PM

markj added inline comments.

sys/compat/linuxkpi/common/src/linux_80211.c
1190	I believe the caller is expected to lock it. This function re-acquires the lock further below. I did miss a refcount leak though.

bz accepted this revision.Dec 7 2024, 1:42 AM

This revision is now accepted and ready to land.Dec 7 2024, 1:42 AM

grahamperrin added a subscriber: grahamperrin.Dec 8 2024, 9:23 AM

Closed by commit rG926905796749: linuxkpi: Fix a lock leak in lkpi_sta_scan_to_auth() (authored by markj). · Explain WhyDec 13 2024, 8:30 PM

This revision was automatically updated to reflect the committed changes.

markj marked an inline comment as done.

markj added a commit: rG926905796749: linuxkpi: Fix a lock leak in lkpi_sta_scan_to_auth().

markj added a commit: rG2a6c77b343f6: linuxkpi: Fix a lock leak in lkpi_sta_scan_to_auth().Mon, Dec 23, 4:53 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

src/

linux_80211.c

2 lines

Diff 147622

View Options

sys/compat/linuxkpi/common/src/linux_80211.c

linuxkpi: Fix a lock leak in lkpi_sta_scan_to_auth()ClosedPublicActions