Paths

Table of Contentst

Differential D47907

init_main: Use TUNABLE_INT_FETCH to initialize verbose_sysinit
ClosedPublic
Actions

Authored by zlei on Dec 4 2024, 12:22 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 24, 10:42 PM

	Unknown Object (File)
	Wed, Nov 19, 5:36 AM

	Unknown Object (File)
	Sun, Nov 16, 9:41 AM

	Unknown Object (File)
	Tue, Nov 4, 5:37 AM

	Unknown Object (File)
	Mon, Nov 3, 12:38 AM

	Unknown Object (File)
	Oct 26 2025, 5:20 AM

	Unknown Object (File)
	Oct 16 2025, 12:54 AM

	Unknown Object (File)
	Sep 20 2025, 10:13 PM

View All 59 Files

Subscribers

Details

Reviewers

kevans
cperciva

Commits

rGf6e0690dc9f2: init_main: Use TUNABLE_INT_FETCH to initialize verbose_sysinit
rG9c6454fe7048: init_main: Use TUNABLE_INT_FETCH to initialize verbose_sysinit
rGa7cfcb264512: init_main: Use TUNABLE_INT_FETCH to initialize verbose_sysinit

Summary

It is too late to initialize verbose_sysinit via TUNABLE_INT, as
TUNABLE_INT run at the order of SI_SUB_TUNABLES, thus any subsystems
those have order prior or equal to SI_SUB_TUNABLES are not logged.

MFC after: 1 week

Test Plan

Boot with debug.verbose_sysinit enabled.

# dmesg
---<<BOOT>>---
subsystem 6fffff
   madt_register(0)... done.
   apic_init(0)... done.
subsystem 700000
   mp_setmaxid(0)... done.
   tunable_int_init(&__tunable_int_102)... done.
   tunable_int_init(&__tunable_int_104)... done.
   tunable_int_init(&__tunable_int_106)... done.
   tunable_int_init(&__tunable_int_197)... done.
...

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

zlei created this revision.Dec 4 2024, 12:22 PM

Herald added subscribers: olce, imp. · View Herald TranscriptDec 4 2024, 12:22 PM

zlei requested review of this revision.Dec 4 2024, 12:22 PM

zlei updated this revision to Diff 147467.Dec 4 2024, 12:41 PM

zlei mentioned this in D47904: init_main: Fix logging the subsystem of pre-loaded kernel modules.

zlei added a parent revision: D47904: init_main: Fix logging the subsystem of pre-loaded kernel modules.

zlei added a child revision: D47909: boottrace: Fix tracing the execution of SYSINITs.Dec 4 2024, 2:22 PM

Heh, whoops-

This revision is now accepted and ready to land.Dec 4 2024, 3:28 PM

Closed by commit rGa7cfcb264512: init_main: Use TUNABLE_INT_FETCH to initialize verbose_sysinit (authored by zlei). · Explain WhyDec 6 2024, 1:48 PM

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rGa7cfcb264512: init_main: Use TUNABLE_INT_FETCH to initialize verbose_sysinit.

zlei added a commit: rG9c6454fe7048: init_main: Use TUNABLE_INT_FETCH to initialize verbose_sysinit.Dec 15 2024, 2:21 AM

zlei added a commit: rGf6e0690dc9f2: init_main: Use TUNABLE_INT_FETCH to initialize verbose_sysinit.Dec 15 2024, 3:44 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

4 lines

Diff 147467

sys/kern/init_main.c

Loading...