sockstat: Ensure that there is always a space between columns
ClosedPublic
Actions

Authored by markj on Fri, Nov 29, 3:52 PM.

Details

Reviewers

Commits

rG60786eb3fe7f: sockstat: Ensure that there is always a space between columns
rGfbd3448614fb: sockstat: Ensure that there is always a space between columns

Summary

MFC after: 2 weeks
PR: 282978

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60874
Build 57758: arc lint + arc unit

Event Timeline

markj created this revision.Fri, Nov 29, 3:52 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Nov 29, 3:52 PM

markj requested review of this revision.Fri, Nov 29, 3:52 PM

Harbormaster completed remote builds in B60874: Diff 147163.Fri, Nov 29, 3:52 PM

This looks like a good incremental change, although I can't test it right now. But this program is also begging for some TLC. It could benefit from libxo output, and it's also a good candidate for a C++ conversion. The entire -w option seems like an avoidable hack, if output were printed more intelligently. Most ambitiously of all, this program is fairly begging for some kind of "xo_print_table" function, that would automatically size the columns. But your change is still a good one by itself.

This revision is now accepted and ready to land.Fri, Nov 29, 6:23 PM

In D47840#1090671, @asomers wrote:

This looks like a good incremental change, although I can't test it right now. But this program is also begging for some TLC. It could benefit from libxo output, and it's also a good candidate for a C++ conversion. The entire -w option seems like an avoidable hack, if output were printed more intelligently. Most ambitiously of all, this program is fairly begging for some kind of "xo_print_table" function, that would automatically size the columns. But your change is still a good one by itself.

I can only agree.

Closed by commit rGfbd3448614fb: sockstat: Ensure that there is always a space between columns (authored by markj). · Explain WhyWed, Dec 4, 6:35 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGfbd3448614fb: sockstat: Ensure that there is always a space between columns.

markj added a commit: rG60786eb3fe7f: sockstat: Ensure that there is always a space between columns.Wed, Dec 18, 1:47 PM