Page MenuHomeFreeBSD

sockstat: Ensure that there is always a space between columns
ClosedPublic

Authored by markj on Nov 29 2024, 3:52 PM.
Tags
None
Referenced Files
F107402589: D47840.diff
Mon, Jan 13, 4:22 PM
Unknown Object (File)
Fri, Jan 10, 5:46 AM
Unknown Object (File)
Fri, Dec 27, 9:09 AM
Unknown Object (File)
Fri, Dec 27, 7:28 AM
Unknown Object (File)
Fri, Dec 27, 6:06 AM
Unknown Object (File)
Thu, Dec 26, 8:42 PM
Unknown Object (File)
Thu, Dec 26, 12:13 PM
Unknown Object (File)
Dec 11 2024, 8:21 AM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60874
Build 57758: arc lint + arc unit

Event Timeline

markj requested review of this revision.Nov 29 2024, 3:52 PM
asomers added a subscriber: asomers.

This looks like a good incremental change, although I can't test it right now. But this program is also begging for some TLC. It could benefit from libxo output, and it's also a good candidate for a C++ conversion. The entire -w option seems like an avoidable hack, if output were printed more intelligently. Most ambitiously of all, this program is fairly begging for some kind of "xo_print_table" function, that would automatically size the columns. But your change is still a good one by itself.

This revision is now accepted and ready to land.Nov 29 2024, 6:23 PM

This looks like a good incremental change, although I can't test it right now. But this program is also begging for some TLC. It could benefit from libxo output, and it's also a good candidate for a C++ conversion. The entire -w option seems like an avoidable hack, if output were printed more intelligently. Most ambitiously of all, this program is fairly begging for some kind of "xo_print_table" function, that would automatically size the columns. But your change is still a good one by itself.

I can only agree.