Page MenuHomeFreeBSD

sockstat: Ensure that there is always a space between columns
ClosedPublic

Authored by markj on Nov 29 2024, 3:52 PM.
Tags
None
Referenced Files
F169696465: D47840.id147503.diff
Wed, Sep 2, 7:50 AM
F169600295: D47840.id147163.diff
Wed, Sep 2, 1:03 AM
F169531294: D47840.id147163.diff
Tue, Sep 1, 8:17 PM
Unknown Object (File)
Mon, Aug 31, 2:00 PM
Unknown Object (File)
Sun, Aug 30, 8:18 PM
Unknown Object (File)
Tue, Aug 25, 6:23 AM
Unknown Object (File)
Tue, Aug 25, 6:21 AM
Unknown Object (File)
Sun, Aug 23, 5:32 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Nov 29 2024, 3:52 PM
asomers added a subscriber: asomers.

This looks like a good incremental change, although I can't test it right now. But this program is also begging for some TLC. It could benefit from libxo output, and it's also a good candidate for a C++ conversion. The entire -w option seems like an avoidable hack, if output were printed more intelligently. Most ambitiously of all, this program is fairly begging for some kind of "xo_print_table" function, that would automatically size the columns. But your change is still a good one by itself.

This revision is now accepted and ready to land.Nov 29 2024, 6:23 PM

This looks like a good incremental change, although I can't test it right now. But this program is also begging for some TLC. It could benefit from libxo output, and it's also a good candidate for a C++ conversion. The entire -w option seems like an avoidable hack, if output were printed more intelligently. Most ambitiously of all, this program is fairly begging for some kind of "xo_print_table" function, that would automatically size the columns. But your change is still a good one by itself.

I can only agree.