sound: Remove dead code from pcm/
ClosedPublic
Actions

Authored by christos on Nov 25 2024, 2:12 PM.

Details

Reviewers

markj
emaste
dev_submerge.ch

Commits

rG03241eb78078: sound: Remove dead code from pcm/
rG00731aaaed76: sound: Remove dead code from pcm/

Summary

No functional change intended.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60755
Build 57639: arc lint + arc unit

Event Timeline

christos created this revision.Nov 25 2024, 2:12 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 25 2024, 2:12 PM

christos requested review of this revision.Nov 25 2024, 2:12 PM

Harbormaster completed remote builds in B60755: Diff 146906.Nov 25 2024, 2:12 PM

I am open to discussion if it's worth keeping/using anything from this.

christos added inline comments.Nov 25 2024, 2:16 PM

sys/dev/sound/pcm/feeder_rate.c
1672	The comment here should also go if we remove the code below.

markj accepted this revision.Nov 25 2024, 8:26 PM

This revision is now accepted and ready to land.Nov 25 2024, 8:26 PM

I'm fine with the removal. Although it would be interesting to know more about some of the disabled code, it's probably not worth the effort to examine thoroughly.

sys/dev/sound/pcm/dsp.c
1260	These comments don't make sense with `chn_wrupdate()` removed. Please grep, there's more occurrences.
1278	Same here, this comment doesn't make sense with `chn_rdupdate()` removed.

emaste added inline comments.Nov 27 2024, 1:34 PM

sys/dev/sound/pcm/ac97.c
325	It looks like this was done because AC97_READ is sometimes inconsistent so we do it in a loop and ensure we get the same value twice. Maybe the `#if 0`'d code could be useful for debugging in the future, but if we want to keep it we could use something like `#ifdef DEBUG_INCONSISTENT_REGISTER_READS`