Differential D47687
newbus: Only call suspend / resume for attached devices Authored by imp on Wed, Nov 20, 5:57 PM. Tags None Referenced Files
Subscribers
Details If a device is disabled, then it will be in state DS_ALIVE with an Sponsored by: Netflix
Diff Detail
Event Timeline
Comment Actions Hmm, I'm not sure this is what you want. I think you want bus drivers able to still perform bus-specific actions during system suspend, e.g. PCI might want to power down devices that don't have an attached driver. I think instead what you want to do is patch bus_generic_suspend_child and bus_generic_resume_child perhaps like so: /**
* @brief Default function for suspending a child device.
*
* This function is to be used by a bus's DEVICE_SUSPEND_CHILD().
*/
int
bus_generic_suspend_child(device_t dev, device_t child)
{
int error;
+ if (!device_is_attached(child))
+ return (0);
error = DEVICE_SUSPEND(child);
if (error == 0) {
child->flags |= DF_SUSPENDED;
} else {
printf("DEVICE_SUSPEND(%s) failed: %d\n",
device_get_nameunit(child), error);
}
return (error);
}
/**
* @brief Default function for resuming a child device.
*
* This function is to be used by a bus's DEVICE_RESUME_CHILD().
*/
int
bus_generic_resume_child(device_t dev, device_t child)
{
+ if ((child->flags & DF_SUSPENDED) != 0) {
+ DEVICE_RESUME(child);
+ child->flags &= ~DF_SUSPENDED;
+ }
- DEVICE_RESUME(child);
- child->flags &= ~DF_SUSPENDED;
return (0);
} | |||||||||||||||||||||||||||||