LinuxKPI: firmware: change order filenames trying to load firmware
ClosedPublic
Actions

Authored by bz on Nov 20 2024, 1:17 PM.

Details

Reviewers

imp
emaste

Group Reviewers

linuxkpi

Commits

rG30d2f84ef2cb: LinuxKPI: firmware: change order filenames trying to load firmware

Summary

Given we have the support in main and stable/14 to load plain firmware
files from /boot/firmware/ and make use of that, switch the order to
try the original unmangled filename and path first before trying any
replacements.
This reduces time and console noise (especially under bootverbose).

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 60702
Build 57586: arc lint + arc unit

Event Timeline

bz created this revision.Nov 20 2024, 1:17 PM

Herald added a subscriber: emaste. · View Herald TranscriptNov 20 2024, 1:17 PM

bz requested review of this revision.Nov 20 2024, 1:17 PM

Harbormaster completed remote builds in B60700: Diff 146744.Nov 20 2024, 1:17 PM

emaste added inline comments.Nov 20 2024, 1:39 PM

sys/compat/linuxkpi/common/src/linux_firmware.c
91–101	"if we have not yet" seems odd with this as the first attempt, unless I am missing something?

Update comment as pointed out by @emaste.

sys/compat/linuxkpi/common/src/linux_firmware.c
91–101	Ah; I had swapped the labels. I'll remove that.

Harbormaster completed remote builds in B60702: Diff 146747.Nov 20 2024, 2:27 PM

LGTM

Can we simplify this eventually and standardize on only the first case?

In D47682#1087412, @emaste wrote:

LGTM

Can we simplify this eventually and standardize on only the first case?

I would love that but @manu or @wulf or someone would have to fix the gpu-firmware bits for this. I noticed yesterday that it's still shipping .ko files.
Wireless firmware is through and done apart from removing bits from src.git now.
I don't know if anything else uses LinuxKPI firmware.

emaste accepted this revision as: emaste.Nov 21 2024, 6:59 PM

This revision is now accepted and ready to land.Nov 21 2024, 6:59 PM

In D47682#1087414, @bz wrote:

I would love that but @manu or @wulf or someone would have to fix the gpu-firmware bits for this. I noticed yesterday that it's still shipping .ko files.

13-STABLE still sticks to *.ko. We have to wait for 13-EOL

In D47682#1087921, @wulf wrote:

In D47682#1087414, @bz wrote:

I would love that but @manu or @wulf or someone would have to fix the gpu-firmware bits for this. I noticed yesterday that it's still shipping .ko files.

13-STABLE still sticks to *.ko. We have to wait for 13-EOL

Ports can handle that; done for wifi; only have to wait for 14.1 to go EOS to be able to remove it there. I can submit a pull request or PR if it helps.

Closed by commit rG30d2f84ef2cb: LinuxKPI: firmware: change order filenames trying to load firmware (authored by bz). · Explain WhyDec 1 2024, 7:45 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG30d2f84ef2cb: LinuxKPI: firmware: change order filenames trying to load firmware.