Page MenuHomeFreeBSD
Differential D47682

LinuxKPI: firmware: change order filenames trying to load firmware
Needs ReviewPublic
Actions

Authored by bz on Wed, Nov 20, 1:17 PM.

Details

Reviewers
imp
Group Reviewers
linuxkpi
Summary

Given we have the support in main and stable/14 to load plain firmware
files from /boot/firmware/ and make use of that, switch the order to
try the original unmangled filename and path first before trying any
replacements.
This reduces time and console noise (especially under bootverbose).

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 60700
Build 57584: arc lint + arc unit

Event Timeline

bz created this revision.Wed, Nov 20, 1:17 PM
Herald added a subscriber: emaste. · View Herald TranscriptWed, Nov 20, 1:17 PM
bz requested review of this revision.Wed, Nov 20, 1:17 PM
Harbormaster completed remote builds in B60700: Diff 146744.Wed, Nov 20, 1:17 PM
emaste added inline comments.Wed, Nov 20, 1:39 PM
sys/compat/linuxkpi/common/src/linux_firmware.c
91

"if we have not yet" seems odd with this as the first attempt, unless I am missing something?

bz updated this revision to Diff 146747.Wed, Nov 20, 2:27 PM
bz marked an inline comment as done.

Update comment as pointed out by @emaste.

sys/compat/linuxkpi/common/src/linux_firmware.c
91

Ah; I had swapped the labels. I'll remove that.

Harbormaster completed remote builds in B60702: Diff 146747.Wed, Nov 20, 2:27 PM
emaste added a comment.Wed, Nov 20, 2:29 PM

LGTM

Can we simplify this eventually and standardize on only the first case?

bz added subscribers: wulf, manu.Wed, Nov 20, 2:34 PM
In D47682#1087412, @emaste wrote:

LGTM

Can we simplify this eventually and standardize on only the first case?

I would love that but @manu or @wulf or someone would have to fix the gpu-firmware bits for this. I noticed yesterday that it's still shipping .ko files.
Wireless firmware is through and done apart from removing bits from src.git now.
I don't know if anything else uses LinuxKPI firmware.

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
src/
22 lines

Diff 146744

View Options

sys/compat/linuxkpi/common/src/linux_firmware.c

Loading...