arm64: Adjust the MPASS in vfp_save_state_savectx
ClosedPublic
Actions

Authored by andrew on Oct 22 2024, 2:24 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Feb 25, 4:06 AM

	Unknown Object (File)
	Fri, Feb 21, 3:59 AM

	Unknown Object (File)
	Tue, Feb 18, 5:56 PM

	Unknown Object (File)
	Sun, Feb 9, 1:05 AM

	Unknown Object (File)
	Sun, Feb 9, 1:04 AM

	Unknown Object (File)
	Thu, Feb 6, 3:53 PM

	Unknown Object (File)
	Jan 17 2025, 3:28 PM

	Unknown Object (File)
	Jan 14 2025, 4:29 PM

View All 21 Files

Subscribers

emaste

imp

Details

Reviewers

manu

Group Reviewers

arm64

Commits

rG9ff643a8da47: arm64: Adjust the MPASS in vfp_save_state_savectx

Summary

In vfp_save_state_savectx we check if the pcb has a NULL vfp state.
When it's called multiple times with the same pcb then we can panic
because the vfp state has been set.

Weaken the requirement for the state pointer to be NULL by also
allowing it to point to the pcb vfp state area we are about to use.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Oct 22 2024, 2:24 PM

Herald added a reviewer: manu. · View Herald TranscriptOct 22 2024, 2:24 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.Oct 22 2024, 2:24 PM

Harbormaster completed remote builds in B60148: Diff 145347.Oct 22 2024, 2:24 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 19 2024, 5:48 PM

Closed by commit rG9ff643a8da47: arm64: Adjust the MPASS in vfp_save_state_savectx (authored by andrew). · Explain Why

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG9ff643a8da47: arm64: Adjust the MPASS in vfp_save_state_savectx.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

vfp.c

9 lines

Diff 146712

View Options

arm64: Adjust the MPASS in vfp_save_state_savectxClosedPublicActions